Repository navigation
Bind terminal follower assertions to the original expiry decision - #723
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The protected 0.6 qualification exposed an invalid test assumption: a DefaultCompatibility queued follower may reach its own strict deadline before terminal retirement. Bind the expected first cause to its actual admitted due time and the producer clock at the first termination-port entry, before connected termination observation can advance that clock. Preserve no follower ABI/Post, once-only identity/order, output fencing and whole-worker retirement assertions.
Add six reducer and three actual Host.CreateConnected before/exact/after controls. Both existing real terminal families retain all 36 browser cases. Runtime parser/lifecycle/ABI, version, capacities, clocks and workflow remain unchanged; 0.6 is unpublished.
Validation: existing clean-source inert workflow preflight and JavaScript syntax checks PASS. Original PR723 attempt39082520529 compiled and passed all50 Lifecycle controls, including the nine new boundaries, then failed29/7 in the36-case browser cohort. All seven failures were the new helper comparing an actual empty Uint8Array against plain []; the repair compares its actual bytes with Array.from, preserving all other assertions. Assertions after that failed comparison remain unqualified until the fresh exact head passes. Independent exact-source review PASS at fae6b00; coherent Atlas capture is included. New compilation/Fable, boundary controls, real browser cleanup and full 35-minute hosted fit remain unqualified until this exact head passes required CI.
Preserve original protected failure 39080719438: 35 browser passes and one follower-reason assertion failure, including a passed instruction-dense case. It produced no eligible package custody. The earlier successful PR qualification remains scoped to its exact source/run.
Owning outcome: Game718. Atlas game/closed-worker-build-boundary retains the original failure and connected clock lesson. No publication, served-feed installed qualification, consumer/image/native activation or whole-product acceptance is selected.