Skip to content

Log leaf-node reduction at INFO level #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
StefanZoerner wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Log leaf-node reduction at INFO level #103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions codewiki/src/be/dependency_analyzer/topo_sort.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,13 +310,17 @@ def concise_node(leaf_nodes: Set[str]) -> Set[str]:

concise_leaf_nodes = concise_node(leaf_nodes)
if len(concise_leaf_nodes) >= LEAF_REDUCTION_THRESHOLD:
logger.debug(f"Leaf nodes are too many ({len(concise_leaf_nodes)}), removing dependencies of other nodes")
count_before = len(concise_leaf_nodes)
logger.info("Leaf nodes are too many (%d >= %d); reducing to components "
"that nothing else depends on.",
count_before, LEAF_REDUCTION_THRESHOLD)
# Remove nodes that are dependencies of other nodes
for node, deps in acyclic_graph.items():
for dep in deps:
leaf_nodes.discard(dep)

concise_leaf_nodes = concise_node(leaf_nodes)
logger.info("Reduced from %d to %d leaf nodes.", count_before, len(concise_leaf_nodes))

if not leaf_nodes:
logger.warning("No leaf nodes found in the graph")
Expand Down