Feature/backend - #3
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 13bf5127ad
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const deployedWasmHash = instance.executable.wasmHash.toString().toLowerCase(); | ||
| if (this.expectedVaultWasmHash && deployedWasmHash !== this.expectedVaultWasmHash) { |
There was a problem hiding this comment.
Encode the Wasm hash as hex before comparison
Whenever STELLAR_VAULT_WASM_HASH is configured—as it is in the committed example—the SDK exposes wasmHash as binary bytes, and calling toString() without an encoding decodes those bytes as UTF-8 rather than producing the expected 64-character hexadecimal hash. The comparison therefore reports a mismatch for the correct deployment, causing /health, /stellar/network, and the admin service health check to return 503; convert the bytes with toString('hex') before lowercasing and comparing.
Useful? React with 👍 / 👎.
No description provided.