Skip to content

Feature/backend - #3

Merged
pjbrion-fwdpeers merged 5 commits into
mainfrom
feature/backend
Sep 2, 2026
Merged

Feature/backend#3
pjbrion-fwdpeers merged 5 commits into
mainfrom
feature/backend

Conversation

@pjbrion-fwdpeers

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread scripts/health-check.mjs Fixed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 13bf5127ad

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread backend/src/stellar/stellar.service.ts Outdated
Comment on lines +139 to +140
const deployedWasmHash = instance.executable.wasmHash.toString().toLowerCase();
if (this.expectedVaultWasmHash && deployedWasmHash !== this.expectedVaultWasmHash) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Encode the Wasm hash as hex before comparison

Whenever STELLAR_VAULT_WASM_HASH is configured—as it is in the committed example—the SDK exposes wasmHash as binary bytes, and calling toString() without an encoding decodes those bytes as UTF-8 rather than producing the expected 64-character hexadecimal hash. The comparison therefore reports a mismatch for the correct deployment, causing /health, /stellar/network, and the admin service health check to return 503; convert the bytes with toString('hex') before lowercasing and comparing.

Useful? React with 👍 / 👎.

@pjbrion-fwdpeers
pjbrion-fwdpeers merged commit cabccf3 into main Sep 2, 2026
8 checks passed
@pjbrion-fwdpeers
pjbrion-fwdpeers deleted the feature/backend branch September 2, 2026 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants