moved ParagraphText specific code from createStyledTextNode() methods to class ParagraphText#617
Merged
JordanMartinez merged 1 commit intoFXMisc:masterfrom Oct 16, 2017
Conversation
… to class ParagraphText
Contributor
|
Thanks for the PR. |
Contributor
|
I forgot to check whether you fix this in the demos as well. I don't think you do in this PR. Sorry about that. That's on me, not you. |
Contributor
|
Nevermind the earlier comment. By putting the code in |
JFormDesigner
pushed a commit
to JFormDesigner/RichTextFX
that referenced
this pull request
Oct 17, 2017
…d for demos since merging PR FXMisc#617)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The moved code is IMHO an implementation detail that belongs to class
ParagraphTextand not to demos.As stated in this comment I'm still not sure whether binding
TextExt.selectionFilltoTextExt.fillmakes any sense. I can't see any difference without this binding. In PR #428 I've also removed this binding and replace with bindingTextExt.selectionFilltoParagraphText.highlightTextFill, but as long as the JDK is not fixed, styling text color of selection does not work at all...