fix(approximator): remove stale MSRBiased reference that breaks import#3
Merged
Merged
Conversation
MSRBiased was listed in SV_APPROXIMATORS and __all__ but never defined or imported (leftover from a main merge), so importing shapiq.approximator raised NameError. Removing the two dangling references restores the import.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
MSRBiasedis listed inSV_APPROXIMATORSand__all__insrc/shapiq/approximator/__init__.py, but it is never defined or imported anywhere in the package (leftover from amainmerge —mainitself no longer has it). BecauseSV_APPROXIMATORS = [..., MSRBiased, ...]is built at import time, simply runningimport shapiq.approximatorraisesNameError.This blocks the OddSHAP reproduction notebook/example from importing, and — more importantly — once
oddshap_approximatoris merged intommschlk:main(PR mmschlk#522), it would carry this dangling reference back intomainand break the import there too.Fix
Remove the two dangling
MSRBiasedreferences. One file, two deletions.import shapiq.approximatorworks again; no behavior change.Verification
upstream/mainandorigin/maindo not containMSRBiased— this is branch-local only.import shapiq.approximatorsucceeds and the full SV approximator list resolves.