Skip to content

Conversation

@factory-ben
Copy link
Collaborator

No description provided.

@factory-droid
Copy link
Contributor

factory-droid bot commented Nov 30, 2025

Droid finished @factory-ben's task —— View job


Code Review Complete

Reviewed the PR which adds hook example files and a minor README grammar fix.

Summary:

  • Left 2 inline comments on examples/hooks/bash-validator.sh with minor improvement suggestions:
    1. Using printf instead of echo for more reliable handling of commands starting with - flags
    2. Regex pattern clarification for matching literal asterisks in rm -rf *

Both are minor robustness improvements for the example code. No blocking issues found.

Adds a complete example demonstrating PreToolUse hooks for validating
bash commands, including sample settings.

- Use printf instead of echo for reliable handling of command strings
- Fix regex patterns to properly match literal asterisks
@factory-ben factory-ben force-pushed the fix/broken-hooks-example-link branch from cc8d4d1 to 7173406 Compare November 30, 2025 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants