QA-BitVMX: Added test scenarios to cover witness construction.#80
Merged
QA-BitVMX: Added test scenarios to cover witness construction.#80
Conversation
Ignacio-87
approved these changes
Feb 27, 2026
jonasmartin
reviewed
Mar 3, 2026
Comment on lines
+1768
to
+1772
| // Verify the script is present in witness (second-to-last element for taproot) | ||
| assert!( | ||
| witness.len() >= 2, | ||
| "Witness must contain script and control block" | ||
| ); |
Contributor
There was a problem hiding this comment.
this second assert does not make sense
Collaborator
Author
There was a problem hiding this comment.
Yes, redundant. Will be removed in following PR
jonasmartin
reviewed
Mar 3, 2026
| .derive_keypair(BitcoinKeyType::P2tr, 0) | ||
| .unwrap(); | ||
|
|
||
| let _ecdsa_key = tc |
Contributor
There was a problem hiding this comment.
the use of _ is for unused variables
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Scenarios: Witness Construction & Leaf Selection
1.P2WSH Skip‑Signing Witness
Objective: Validate witness construction for SegWit script with no signature (SignMode::Skip).
2.Taproot Witness: Invalid Leaf Index
Objective: Ensure invalid leaf index is rejected during witness building.
Taproot Mixed SignModes in Single Output
Witness Stack Order and Correctness Validation
Taproot Skip-Mode with Multiple Inputs
Objective: Validate that Skip-mode leaves do not interfere with signature-requiring leaves when multiple inputs exist in same transaction.
https://github.com/orgs/FairgateLabs/projects/4/views/1?pane=issue&itemId=134592380