Add support for Helm charts deployed via ArgoCD Application CRs#427
Open
fuljo wants to merge 2 commits intoFairwindsOps:masterfrom
Open
Add support for Helm charts deployed via ArgoCD Application CRs#427fuljo wants to merge 2 commits intoFairwindsOps:masterfrom
fuljo wants to merge 2 commits intoFairwindsOps:masterfrom
Conversation
fuljo
force-pushed
the
feat/argocd-helm
branch
from
ad7e0df to
bf06f4a
Compare
fuljo
force-pushed
the
feat/argocd-helm
branch
2 times, most recently
from
a19271b to
a5fae11
Compare
fuljo
force-pushed
the
feat/argocd-helm
branch
from
a5fae11 to
1f8eec8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #45
Checklist
Description
What's the goal of this PR?
Allowing users to check outdated Helm releases deployed via ArgoCD.
These did not show up since ArgoCD only inflates the charts via
helm template, as stated in the documentation.What changes did you make?
The feature has been implemented with minimal impact on the codebase.
I've introduced new functions that query the chart for ArgoCD
ApplicationCRs and convert them to HelmReleases.After this query phase, the filtering is the same as for regular Helm releases.
What alternative solution should we consider, if any?
The current implementation treats ArgoCD-deployed Helm Releases as regular Helm Releases.
One may want to implement a command-line switch to avoid querying these releases.
However, this change would require passing additional context into the
GetHelmReleasesfunction, which currently doesn't get command line arguments.