Skip to content

Comments

[FEATURE] Add title-based ignore list for windows#441

Open
PhoenixFlame101 wants to merge 1 commit intoFancyWM:mainfrom
PhoenixFlame101:float-by-title
Open

[FEATURE] Add title-based ignore list for windows#441
PhoenixFlame101 wants to merge 1 commit intoFancyWM:mainfrom
PhoenixFlame101:float-by-title

Conversation

@PhoenixFlame101
Copy link

Float windows automatically based on the window title, similar to the functionality provided by the class and process ignore lists.

This feature is something I would like to make my current setup work: Godot and my external editor tiled, but the game debug window floating. I can't use the existing functionality since both windows have the same process and class. This was already requested in #200, but it seems it did not get any response. There is also another similar issue #83, but this PR might not fully solve that use-case.

I implemented the feature by extending the IWindowMatcher framework with ByTitleMatcher class and TitleIgnoreList property, following the pattern used for the already existing exclusion types.

Float windows automatically based on the window title, similar to the
functionality provided by the class and process ignore lists
@veselink1
Copy link
Collaborator

Looks pretty good. I have known Title-based rule has been possible to do for a while, but didn't have time to implement it, so thank you for doing so.

I plan to test it manually later and should be good to merge, since code-wise it LGTM.

MS Store build failure can be ignored. It is because of different warning configuration around nullability, I wasn't aware of and which originated from the winman-window repo. Rebase will fix it though.

@veselink1 veselink1 self-assigned this Feb 15, 2026
@veselink1
Copy link
Collaborator

Actually, I can see two UX issues that we may need to address.

  • Should the exclusion rule be applied when the title changes to match the rule?
    • Your change only excludes windows whose initial title matches the Regex.
  • Should the exclusion rule be reverted when the title no longer matches the rule?
    • I'm not sure what the expected behaviour is here.

I think we don't need to solve both of these at this time, but if we are not solving them now, we should make it clear to users in the UI, that the rule is only checked the first time the window is created.

I think the strongest indicator that we need to merge this is, if it was useful for your Godot use case? Was the check as it exists sufficient for your workflow?

@PhoenixFlame101
Copy link
Author

For me personally, the feature fits my use case as it is currently. Godot's game window includes the project name and the word DEBUG, so filtering by that works for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants