Improve tool calling response handling#38
Closed
MichaelAnders wants to merge 1 commit intoFast-Editor:mainfrom
Closed
Improve tool calling response handling#38MichaelAnders wants to merge 1 commit intoFast-Editor:mainfrom
MichaelAnders wants to merge 1 commit intoFast-Editor:mainfrom
Conversation
- Add fallback parsing for Ollama models that return tool calls as JSON text in message content instead of using the structured tool_calls field - Return tool results directly to CLI instead of making a follow-up LLM call, reducing latency and preventing hallucinated rewrites of output - Add dedicated Glob tool returning plain text (one path per line) instead of JSON, with workspace_list accepting both 'pattern' and 'patterns' - Clarify why Glob is not aliased to workspace_list (format mismatch)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tool_callsfieldworkspace_listaccepting bothpatternandpatternsworkspace_list(format mismatch)Files Changed
src/clients/ollama-utils.jssrc/orchestrator/index.jssrc/tools/index.jssrc/tools/indexer.jsTest plan
workspace_listaccepts bothpatternandpatternsparametersFound some issues, removing for now