Fix varios bugs: tipo faltante, animaciones y código duplicado#1
Open
FedericoSecchi wants to merge 1 commit into
Open
Fix varios bugs: tipo faltante, animaciones y código duplicado#1FedericoSecchi wants to merge 1 commit into
FedericoSecchi wants to merge 1 commit into
Conversation
- Agrega interfaz ScreenBreakState faltante en FocusTimerContext.tsx - Corrige animación de salida en ScreenBreakBanner: AnimatePresence ahora siempre está montado para que la animación exit funcione - Elimina doble condición if (import.meta.env.DEV) anidada en AuthContext - Agrega data:null faltante en returns de error en signIn/signUp - Simplifica lógica redundante en useIdleReminder.markActivity https://claude.ai/code/session_01MdEb77Vxh9hAnwnSPw4KRa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://claude.ai/code/session_01MdEb77Vxh9hAnwnSPw4KRa
Note
Low Risk
Low risk: small UI animation fix and minor correctness/consistency tweaks to auth return shapes and idle reminder state handling, with no changes to auth flows or persisted data schemas.
Overview
Fixes the
ScreenBreakBannerexit animation by keepingAnimatePresencemounted and rendering the banner via a singleshouldShowcondition with a stablekey.Cleans up small bugs/inconsistencies: removes duplicated
if (import.meta.env.DEV)blocks inAuthContext, makessignIn/signUperror returns consistently includedata: null, adds the missingScreenBreakStatetype inFocusTimerContext, and simplifiesuseIdleReminder.markActivityto always clear the shown flag.Written by Cursor Bugbot for commit 46d2205. This will update automatically on new commits. Configure here.