Conversation
Contributor
Author
|
Contributor
Author
|
Some commands update the nonce before; some update the nonce after. Thereby 6af8698 broke the script. I will need to patch it there. |
wjmelements
added a commit
to FilOzone/filecoin-services
that referenced
this pull request
Jan 27, 2026
Reviewer @rvagg [Context](FilOzone/foc-devnet#44 (comment)) Updating nonce after a command is most common in this script. There are some exceptions though, and such an inversion can cause wrong nonce. #### Changes * always update nonce after command, never before #### Test Plan `SKIP_LOAD_DEPLOYMENTS=true tools/deploy-all-warm-storage.sh`
Contributor
Author
|
Next error is |
redpanda-f
approved these changes
Jan 27, 2026
Contributor
|
eggselent! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #41
Dependencies FilOzone/synapse-sdk#568 FilOzone/filecoin-services#399
Reviewer @redpanda-f
Context
Filecoin Services PR FilOzone/filecoin-services#386
Synapse PR FilOzone/synapse-sdk#553
FOC Task: #41
synapse now depends on an endorsements contract.
It uses this contract to prefer reputable service providers and improve durability until a repair solution can be developed.
This contract must be deployed into devnet and its address must be provided to synapse.
Changes