Validate FOC_DEVNET_BASEDIR is not empty before use#54
Closed
Copilot wants to merge 4 commits intofeat/redpanda/configurable-base-dirfrom
Closed
Validate FOC_DEVNET_BASEDIR is not empty before use#54Copilot wants to merge 4 commits intofeat/redpanda/configurable-base-dirfrom
Copilot wants to merge 4 commits intofeat/redpanda/configurable-base-dirfrom
Conversation
Co-authored-by: redpanda-f <181817029+redpanda-f@users.noreply.github.com>
Collaborator
|
I do not like the fallback to /tmp/..., if it is not set, we should still use ~/.foc-devnet |
Co-authored-by: redpanda-f <181817029+redpanda-f@users.noreply.github.com>
Co-authored-by: redpanda-f <181817029+redpanda-f@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP to address feedback on FOC_DEVNET_BASERDIR support
Validate FOC_DEVNET_BASEDIR is not empty before use
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
FOC_DEVNET_BASEDIRenvironment variable was used without validating it's non-empty, causing paths to resolve relative to the current directory when set to""or whitespace.Changes:
trim().is_empty()check infoc_devnet_home()to fall back to default when env var is empty/whitespaceserial_testto prevent race conditions in tests that modify global env state✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.