Skip to content

fix(core): release subscriptions on unmount and evict errored cache entries #839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jhuleatt wants to merge 21 commits into
base: main
Choose a base branch
from
+831 −119
Open

fix(core): release subscriptions on unmount and evict errored cache entries #839

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
36d6643
fix(core): release subscriptions on unmount and evict errored cache e…
jhuleatt Oct 27, 2026
b092103
test(core): add error-after-unmount test (#485) and avoid top-level i…
jhuleatt Oct 27, 2026
ae14caa
fix(core): require rxjs ^7.1.0, evict unconsumed completed warmups, a…
jhuleatt Oct 28, 2026
8f99728
fix(core): evict immediately when an unmounted listener errors (#485)
jhuleatt Oct 28, 2026
d9d2a97
fix(core): scope inner subscription teardown per subscriber in Suspen…
jhuleatt Oct 28, 2026
2b2f4fb
Merge branch 'main' into fix/suspense-subject-leak
tyler-reitz Nov 4, 2026
eb7910f
fix(core): keep Suspense first-load errors cached and tear down forei…
tyler-reitz Nov 4, 2026
0c7c91a
test(core): guard the error-to-completion branch in SuspenseSubject
tyler-reitz Nov 4, 2026
587e430
fix(core): keep the Suspense error policy for preload-created entries
tyler-reitz Nov 5, 2026
b73bc24
fix(sdk): run each useInit* initializer once per app
tyler-reitz Nov 5, 2026
909ce46
docs: regenerate reference docs
tyler-reitz Nov 5, 2026
f5598c1
fix(core): wait for the first emission before releasing an entry
armando-navarro Nov 6, 2026
19c8c30
test(core): cover the lifecycle paths the suite could not see
armando-navarro Nov 6, 2026
2908453
docs: regenerate reference docs
tyler-reitz Nov 6, 2026
6c33768
refactor(core): drop an unneeded cast in SuspenseSubject
tyler-reitz Nov 6, 2026
b16d42a
refactor(core): trim SuspenseSubject comments
tyler-reitz Nov 6, 2026
7a69906
refactor(core): remove dead code and unclear names in SuspenseSubject
tyler-reitz Nov 6, 2026
8e667be
refactor(core): address remaining #839 review comments
tyler-reitz Nov 6, 2026
364c08a
test(core): cover the re-register of an evicted entry and its skip cases
tyler-reitz Nov 6, 2026
12c4a65
fix(sdk): let a rejected useInit* initializer run again on the next m…
tyler-reitz Nov 6, 2026
6738912
docs: regenerate reference docs
tyler-reitz Nov 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions docs/reference/classes/ReactFireError.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/reference/functions/checkIdField.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/reference/functions/checkOptions.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/reference/functions/checkinitialData.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/reference/functions/useAnalytics.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/reference/functions/useAppCheck.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/reference/functions/useAuth.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/reference/functions/useDatabase.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/reference/functions/useFirestore.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/reference/functions/useFunctions.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/reference/functions/useObservable.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/reference/functions/usePerformance.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/reference/functions/useRemoteConfig.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/reference/functions/useStorage.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 7 additions & 7 deletions docs/reference/interfaces/ObservableStatus.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions docs/reference/interfaces/ReactFireOptions.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions docs/reference/interfaces/SignInCheckOptionsBasic.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions docs/reference/interfaces/SignInCheckOptionsClaimsObject.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions docs/reference/interfaces/SignInCheckOptionsClaimsValidator.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions docs/reference/type-aliases/ReactFireGlobals.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/reference/variables/AnalyticsProvider.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading