Tighten manifest 25-26, add steps 27-31, relax baseline lock - #479
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #479 +/- ##
=========================================
Coverage 99.35% 99.35%
Complexity 1873 1873
=========================================
Files 132 132
Lines 4805 4805
=========================================
Hits 4774 4774
Misses 31 31 ☔ View full report in Codecov by Harness. |
Firehed
force-pushed
the
manifest/tighten-25-26
branch
from
September 1, 2026 19:39
4b3f39b to
36bfdb1
Compare
Owner
Author
|
Baseline expansion expected due to the nature of adding more restrictive rules. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #473. Scope grew after a second scan surfaced five more M×N patterns not captured by the current manifest, and after the realisation that step-21's baseline hard-lock made new tighten rules impractical.
Tightens to steps 25 and 26
docblockForExpressionbecomes a one-liner it is deleted and inlined rather than kept as a wrapper.Domain\LateBindingKeywordas the sole home (drops the "orScopeFinder::resolveClassName, whichever" hedge); adds atests/Architecture/test that fails if the three keyword literals appear insrc/outside the enum.New steps 27-31 for uncaptured M×N findings
Each ships a
disallowedMethodCallstighten modelled on #478's pattern.ExpressionResolverandMemberAccessDetectorpicksgetResolvableClassNames()[0]whileSymbolResolver::getAccessibleMembersiterates. Failure:function f(A|B $x) { $x->onlyB(); }— completion offersonlyB, hover returns null. Tighten pinsgetResolvableClassNames()to the shared helper.resolveConstFetchuses one lookup,resolveFuncCalliteratesNameContext::candidates. Failure:namespace App; const X = 1; echo X;— hover onXreturns null. Tighten pinsSymbolSource::lookupConstanttoExpressionResolver.SymbolCandidatesreads->docblock+DocblockParser::extractDescriptiondirectly, bypassingHasSymbolLocation::getDocumentation(). Preventive today; a future tag-strip ingetDocumentation()would silently miss completion detail. Tighten pinsDocblockParser::extractDescriptiontoHasSymbolLocation.HoverHandler,SignatureHelpHandler, andCompletionItemFactoryeach composeformat()+getDocumentation()themselves; aResolvedSymbolPresenterconsolidates the shape. Tighten pins the two methods to the presenter.$thistyping has an AST path inExpressionResolverand a text-fallback side-channel inMemberAccessDetector(via aresolvedTypenode attribute). Deletes the attribute; routes both through one helper. Tighten pinsTextFallbackHelper::resolveEnclosingClassNameto that helper.Relaxes bin/check-baseline-shrink NOW
Step-21's script failed if either baseline file existed. That made new tighten rules with residuals impossible to add. Restored the pre-step-21 shrink-only-when-present logic (comparing to
origin/main). The hard "must-not-exist" lock moves to the retire step, by which point every interim tighten will have drained its residual.Beefed-up retire (step-32)
bin/check-baseline-shrink.tests/Architecture/HandlerDependenciesRule.phpthat fails if any handler insrc/Handler/namesParserService,SymbolIndex,MemberResolver, orSymbolSourcedirectly — code-enforcing the "handlers are formatters, not resolvers" invariant that CLAUDE.md documents but nothing enforces today.CLAUDE.mdGuardrails and Architecture Invariants to reflect final state: baselines permanently gone, freeze paragraph deleted, the running list of scopeddisallowedMethodCallstightens named as the seams they pin.Considered and dropped from the scan
TextFallbackHelper::parseCallPatternvsCompletionClassifier) — verifier confirmed they answer different questions on the same input; no feature asymmetry possible.DefaultTextSymbolExtractorvsTextFallbackHelper::findClassLikeDeclarations) —DefaultTextSymbolExtractoris a consumer of the second; already unified.PR body written by AI, reviewed by a human.