Engine: Consolidate CapabilityStatement builder pattern#1200
Merged
kennethmyhra merged 11 commits intoFirelyTeam:r4/masterfrom Apr 26, 2026
Merged
Engine: Consolidate CapabilityStatement builder pattern#1200kennethmyhra merged 11 commits intoFirelyTeam:r4/masterfrom
kennethmyhra merged 11 commits intoFirelyTeam:r4/masterfrom
Conversation
Condition should be 'publisher != null', not 'publisher == null'.
Replace factory-style Func<TComponent> overloads on CapabilityStatementBuilder and RestComponentBuilder with Func<TBuilder, TBuilder> delegates. Callers now receive a pre-constructed builder instance and no longer need to manually instantiate the builder or call .Build(). Updated CapabilityStatementBuilderTests to use the new fluent signatures.
Introduce ServerVersion record with Major, Minor, Patch and optional PreRelease components. ToString() produces 'Major.Minor.Patch' or 'Major.Minor.Patch-PreRelease'. An implicit string operator allows seamless use wherever a string is expected. SparkSettings.Version now returns ServerVersion, parsing file version parts from the assembly and extracting any pre-release suffix from the AssemblyInformationalVersion attribute.
Move away from the old static CapabilityStatementBuilder to Spark's family of Capability Statement Builders.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move away from the static pattern CapabilityStatementBuilder to the fluent instance-based CapabilityStatementBuilder and family of builders.