fix(config): label the update workflow in the picker; drop "expanded-profile" wording - #1632
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe ChangesUpdate workflow
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
alfred-openspec
left a comment
There was a problem hiding this comment.
The picker metadata and optional-workflow wording look sound, and the focused generation/parity tests pass. This head currently conflicts with main in test/core/templates/skill-templates-parity.test.ts, so please rebase and resolve the conflict, then let the new exact-head matrix finish before approval.
…ed-profile" wording The config workflow picker builds each row's label from WORKFLOW_PROMPT_META in src/commands/config.ts. The table had entries for 11 of the 12 workflows but not `update`, so `openspec config` rendered that row as the raw id `update` with a `Workflow: update` placeholder description. Since `update` is one of the six core workflows, every user who opens the picker saw it. Add the missing `update` entry so the row reads "Update change / Revise the planning artifacts of an existing change". Also reword the update-change workflow template, which called `/opsx:continue` and `/opsx:new` "expanded-profile" workflows. There is no "expanded" profile; the only profile values the product stores are `core` and `custom`. They are now described as "optional" workflows. Regenerated the committed skills.sh mirror and parity hashes accordingly. Harden with a regression test asserting every ALL_WORKFLOWS id has real picker metadata (no raw-id name, no "Workflow:" placeholder), so a future workflow addition can't silently reintroduce the fallback. Closes #1627 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
03b287c to
275f2d5
Compare
|
Rebased onto current main. The only conflict was the generated parity-hash file Verification: |
alfred-openspec
left a comment
There was a problem hiding this comment.
The rebase resolves the conflict cleanly, generated skills and parity hashes are current, the focused 164-test suite plus build and lint pass locally, and the full hosted matrix is green. Approved.
…ion-AI#1640) Six user-facing fixes merged after v1.8.0 without a changeset, so they would ship in v1.9.0 with no changelog entry and their authors uncredited. All are patch fixes; the release target stays at 1.9.0. Covers: Fission-AI#1637, Fission-AI#1607, Fission-AI#1632, Fission-AI#1616, Fission-AI#1612, Fission-AI#1523. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Status: LGTM — closes #1627. All affected tests pass; no new failures introduced.
What was wrong
Two small, related defects surfaced in a profile-naming audit:
Unlabeled
updaterow in the config picker.openspec config→ edit workflows shows a checklist of all 12 workflows.WORKFLOW_PROMPT_METAinsrc/commands/config.tshad friendly labels for 11 of them but was missingupdate, so that row fell back to the raw idupdatewith a placeholderWorkflow: updatedescription. Becauseupdateis one of the six core workflows, every user who opens the picker saw it."expanded-profile" survives in template strings. The update-change workflow template called
/opsx:continueand/opsx:new"expanded-profile" workflows. There is no "expanded" profile — the only profile values the product stores arecoreandcustom— so an agent or user looking for one finds nothing.How it was fixed
updateentry toWORKFLOW_PROMPT_META→ the row now reads Update change / Revise the planning artifacts of an existing change.src/core/templates/workflows/update-change.tsfrom "expanded-profile workflow" to "optional workflow".skills/openspec-update-change/SKILL.md) viapnpm generate:skillsand the parity hashes viapnpm regen:parity-hashesso the generated-file parity tests stay green.Proof it works
test/commands/config.test.ts): asserts everyALL_WORKFLOWSid has real picker metadata — no name equal to the raw id, noWorkflow:placeholder — so adding a future workflow can't silently reintroduce the fallback. Reverting theupdateentry makes it fail.distoutput confirms 0 raw-id fallbacks across all 12 workflows.init.test.ts,update-change.test.ts).config-profile,artifact-workflow) reproduce on a clean stash ofmain— pre-existing and unrelated;tsc --noEmitandeslint src/are clean.Scope / notes
🤖 Generated with Claude Code
Summary by CodeRabbit
Workflow Updates
/opsx:continueand/opsx:newas optional workflows.Quality Improvements