Skip to content

moved to the nix crate for abstractions (I wasn't kidding) - #1

Draft
parzivale wants to merge 1 commit into
FixeQD:mainfrom
parzivale:feat/nix
Draft

moved to the nix crate for abstractions (I wasn't kidding)#1
parzivale wants to merge 1 commit into
FixeQD:mainfrom
parzivale:feat/nix

Conversation

@parzivale

Copy link
Copy Markdown

As the title says

@parzivale

Copy link
Copy Markdown
Author

@FixeQD i dont expect you to merge this lmao

@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 755b405e-8e8e-4ccd-9ca6-cd3dd52bf52e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@parzivale

Copy link
Copy Markdown
Author
image this is really the main reason behind this, people generally don't love unsafe code

@FixeQD

FixeQD commented Jul 20, 2026

Copy link
Copy Markdown
Owner

I'll review ts when I'll be home, and it's approx. 29-07-2026
Or I could just review it on my phone

@FixeQD

FixeQD commented Jul 21, 2026

Copy link
Copy Markdown
Owner

What do you think of this
Use

nix = { version = "0.31.3", features = ["user"] }

And the rest from rustix

@parzivale

Copy link
Copy Markdown
Author

Sounds good to me!

…eatures

Move the classic mount(2) wrappers and chown off nix onto rustix (already
a dependency): mount/mount_remount/unmount and rustix::fs::chown. nix keeps
only the `user` feature (User/geteuid/Uid/Gid) plus its always-available
`errno::Errno`, which stays the stored error type — rustix errnos are
converted at each OverlayError site.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants