Closed
Conversation
for more information, see https://pre-commit.ci
khvn26
requested changes
May 5, 2026
Member
khvn26
left a comment
khvn26
left a comment
There was a problem hiding this comment.
I'm not entirely sure what this gains us. The tests will always pass, but we'll have to bump them anyway, even though they're technically a transitive dependency.
I guess what we want here is an eager renovate/dependabot config that always opens a PR against the latest engine.
Same should apply for other SDK implementations that do not include the engine in their code (e.g., Rust).
Contributor
Author
|
My bad, closing as I overlooked the engine handling the test for the python sdk. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrated engine test data suite that was missing in the SDK.
As other SDK, test suite is retrieved from the
engine-test-datarepo and local evaluation is run against them to ensure no regressions.