Skip to content

fix(tasks): make delete_segment idempotent#7392

Open
SAY-5 wants to merge 1 commit intoFlagsmith:mainfrom
SAY-5:fix/delete-segment-idempotent-7354
Open

fix(tasks): make delete_segment idempotent#7392
SAY-5 wants to merge 1 commit intoFlagsmith:mainfrom
SAY-5:fix/delete-segment-idempotent-7354

Conversation

@SAY-5
Copy link
Copy Markdown

@SAY-5 SAY-5 commented May 2, 2026

Closes #7354. .get() raises DoesNotExist when the segment is already deleted; filter().delete() is a no-op.

Closes Flagsmith#7354. .get() raises DoesNotExist when segment was already deleted by another path; use filter().delete().
@SAY-5 SAY-5 requested a review from a team as a code owner May 2, 2026 05:36
@SAY-5 SAY-5 requested review from khvn26 and removed request for a team May 2, 2026 05:36
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 2, 2026

@SAY-5 is attempting to deploy a commit to the Flagsmith Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added the api Issue related to the REST API label May 2, 2026
@SAY-5 SAY-5 changed the title tasks: make delete_segment idempotent fix(tasks): make delete_segment idempotent May 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Issue related to the REST API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Race condition in deleting segments

1 participant