Skip to content

fix(breadcrumb): align current-page item with links and separators#7401

Open
talissoncosta wants to merge 1 commit intomainfrom
fix/breadcrumb-alignment
Open

fix(breadcrumb): align current-page item with links and separators#7401
talissoncosta wants to merge 1 commit intomainfrom
fix/breadcrumb-alignment

Conversation

@talissoncosta
Copy link
Copy Markdown
Contributor

@talissoncosta talissoncosta commented May 4, 2026 •
edited
Loading

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Follow-up to a review comment on #7100 (thread) — the breadcrumb's current-page item sat on a different baseline than the link/separator items, visible as the trailing label being slightly higher or lower than the rest of the trail.

How did you test this code?

  • Storybook → Components/Navigation/Breadcrumb → confirmed all three items (link / / / current) sit on the same baseline.
  • Light + dark mode visually verified.
  • Chromatic snapshot diff (this PR) shows the alignment correction on the existing Breadcrumb stories.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 4, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
flagsmith-frontend-preview Ready Ready Preview, Comment May 5, 2026 11:12am
flagsmith-frontend-staging Ready Ready Preview, Comment May 5, 2026 11:12am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Preview May 5, 2026 11:12am

Request Review

@github-actions github-actions Bot added the front-end Issue related to the React Front End Dashboard label May 4, 2026
@github-actions github-actions Bot added the fix label May 4, 2026
@talissoncosta talissoncosta marked this pull request as ready for review May 4, 2026 13:31
@talissoncosta talissoncosta requested a review from a team as a code owner May 4, 2026 13:31
@talissoncosta talissoncosta requested review from Zaimwa9 and removed request for a team May 4, 2026 13:31
claude[bot]
claude Bot reviewed May 4, 2026
View reviewed changes
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Code review skipped — your organization's overage spend limit has been reached.

Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.

Once credits are available, reopen this pull request to trigger a review.

@github-actions github-actions Bot added fix and removed fix labels May 4, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-7401 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-7401 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-7401 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-7401 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-7401 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-7401 Finished ✅ Results ✅

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026 •
edited
Loading

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  44.8 seconds
commit  dd5a37a
info  🔄 Run: #16511 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  51.1 seconds
commit  dd5a37a
info  🔄 Run: #16511 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  17 passed

Details

stats  17 tests across 14 suites
duration  1 minute, 4 seconds
commit  dd5a37a
info  🔄 Run: #16511 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  43.6 seconds
commit  cbbe4ec
info  🔄 Run: #16524 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  27.5 seconds
commit  cbbe4ec
info  🔄 Run: #16524 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  40.7 seconds
commit  cbbe4ec
info  🔄 Run: #16524 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  17 passed

Details

stats  17 tests across 14 suites
duration  1 minute, 14 seconds
commit  cbbe4ec
info  🔄 Run: #16524 (attempt 1)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026 •
edited
Loading

Visual Regression

16 screenshots compared. See report for details.
View full report

@talissoncosta talissoncosta mentioned this pull request May 4, 2026
Merged
12 tasks
Base automatically changed from feat/storybook-component-stories to main May 4, 2026 15:37
@talissoncosta talissoncosta requested a review from a team as a code owner May 4, 2026 15:37
@talissoncosta @claude
fix(breadcrumb): align current-page item with links and separators
cbbe4ec 
The current-page div had `lh-sm` (line-height: small) while the link
and separator items used the default h6 line-height, so the muted
current page sat on a slightly different baseline than the rest of
the trail. Drops `lh-sm` and replaces it with `mb-0` for consistency
with the other items, so all three (link / separator / current) share
the same baseline inside the flex row.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@talissoncosta talissoncosta force-pushed the fix/breadcrumb-alignment branch from dd5a37a to cbbe4ec Compare May 5, 2026 11:11
@github-actions github-actions Bot added fix and removed fix labels May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@claude claude[bot] claude[bot] left review comments

@Zaimwa9 Zaimwa9 Awaiting requested review from Zaimwa9 Zaimwa9 is a code owner automatically assigned from Flagsmith/flagsmith-front-end

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

fix front-end Issue related to the React Front End Dashboard

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@talissoncosta