Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import org.searchmob.engine.rank.Personalizer
*/
class PersonalizationPreferences(private val store: PreferencesStore) {
suspend fun load(): PersonalizationModel {
val raw = store.get(KEY) ?: return PersonalizationModel()
val raw = runCatching { store.get(KEY) }.getOrNull() ?: return PersonalizationModel()
return Personalizer.fromJson(raw)
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import org.searchmob.engine.rank.RankingRules
*/
class RankingPreferences(private val store: PreferencesStore) {
suspend fun load(): RankingRules {
val raw = store.get(KEY) ?: return withDefaultLenses(RankingRules.EMPTY)
val raw = runCatching { store.get(KEY) }.getOrNull() ?: return withDefaultLenses(RankingRules.EMPTY)
val parsed = runCatching { json.decodeFromString<RankingRules>(raw) }.getOrDefault(RankingRules.EMPTY)
return withDefaultLenses(parsed)
}
Expand Down
29 changes: 29 additions & 0 deletions app/src/test/java/org/searchmob/data/RankingPreferencesTest.kt
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,26 @@ private class FakeRankingStore : PreferencesStore {
override suspend fun clear() = map.clear()
}

/** A store that throws on every read, simulating a locked vault (DEK wiped from memory). */
private class LockedStore : PreferencesStore {
private fun locked(): Nothing = error("vault is locked: DEK not present in memory")

override fun observe(): Flow<Preferences> = locked()

override suspend fun getAll(): Preferences = locked()

override suspend fun get(key: String): String? = locked()

override suspend fun put(
key: String,
value: String,
) = locked()

override suspend fun remove(key: String) = locked()

override suspend fun clear() = locked()
}

class RankingPreferencesTest {
@Test
fun domainRuleSetAndClear() =
Expand Down Expand Up @@ -92,4 +112,13 @@ class RankingPreferencesTest {
val prefs = RankingPreferences(FakeRankingStore())
assertEquals(false, prefs.importJson("not json"))
}

@Test
fun loadReturnsEmptyWhenVaultIsLocked() =
runTest {
val prefs = RankingPreferences(LockedStore())
val rules = prefs.load()
assertEquals(DEFAULT_SAMPLE_LENSES, rules.lenses)
assertTrue(rules.domainRules.isEmpty())
}
}