[0.1.7] Filter InvalidType when warn off - #63
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hides syntax-driven
Docscribe/InvalidTypeannotations when the "Warn on invalid YARD types" setting is off. RBS-sourcedInvalidTypeoffenses always stay visible.Previously the toggle only controlled the
--validate-typesCLI flag, which gates mismatch-vs-inferred reporting in the gem. Syntax-broken YARD types are always emitted by the gem, so turning the setting off had no visible effect in the editor.Changes:
DocscribeAnnotator.applyskips non-RBSInvalidTypeoffenses when the setting is off (with an info log line per skip)isInvalidYardHiddenhelper with unit tests (setting on/off, null source, RBS source, other cops)3h5to assert the skip log line as the OFF oracleChecklist
./gradlew test— 273 tests, 0 failures, including 5 new warn-toggle tests)./gradlew spotlessCheck)./gradlew detekt— fails on a clean tree too withCould not initialize class com.intellij.ide.plugins.PluginEnabler, environment issue, unrelated to this change)./gradlew verifyPlugin— not run in this session)Screenshots (if applicable)
N/A — verified live in VM (case
3h5green: highlight plus quick-fix when on, skip log line when off).