Skip to content

[0.1.7] Gate cli_overrides on 1.6.2 - #65

Merged
unurgunite merged 2 commits into
v0.1.7from
feature/gate-cli-overrides-1.6.2
Sep 18, 2026
Merged

unurgunite merged 2 commits into
v0.1.7from
feature/gate-cli-overrides-1.6.2

Conversation

@unurgunite

@unurgunite unurgunite commented Sep 18, 2026 •

Copy link
Copy Markdown
Member

Description

Fixes Server error: NoMethodError: undefined method 'any?' for nil on projects with docscribe < 1.6.2 (e.g. 1.6.0/1.6.1 on older Rubies).

Root cause: the plugin always sends cli_overrides ({validate_types: true}, plus RBS flags) with every daemon RPC. Daemons before 1.6.2 merge overrides raw into ConfigBuilder, whose filter_overrides? calls options[:include].any? on the partial hash — nil.any? crashes the request. CLI check works fine on the same project, only the daemon path breaks, so every file shows a red Server error squiggle.

Changes:

  • DocscribeDaemon gains supportsCliOverrides(version): daemons older than 1.6.2 get RPC params without cli_overrides and fall back to their own docscribe.yml; unknown versions keep current behavior. Applied to check/fix (buildExecuteParams), check_batch (buildBatchParams) and update_types (buildUpdateTypesParams) via an includeCliOverrides flag (defaults keep existing call sites green).
  • New DocscribeDaemonCliOverridesTest (5 tests): gate on versions below/at/above 1.6.2, unknown versions, and override omission in batch/update-types params.

Checklist

  • Tests pass (./gradlew test — 278 tests, 0 failures, including 5 new gate tests)
  • Formatting clean (./gradlew spotlessCheck)
  • Static analysis clean (./gradlew detekt — fixed LargeClass + MagicNumber findings)
  • Plugin verified (./gradlew verifyPlugin — not run in this session)
  • CHANGELOG updated — N/A, unreleased fix on top of 0.1.7

Screenshots (if applicable)

N/A — verified by unit tests; live check on a 1.6.0 project shows no Server error squiggles after the fix.

@unurgunite unurgunite self-assigned this Sep 18, 2026
@unurgunite unurgunite added the bug Something isn't working label Sep 18, 2026
@unurgunite
unurgunite merged commit d742d47 into v0.1.7 Sep 18, 2026
1 check passed
@unurgunite
unurgunite deleted the feature/gate-cli-overrides-1.6.2 branch September 18, 2026 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant