Migration to Credential Manager for Sign-in process#2755
Draft
Migration to Credential Manager for Sign-in process#2755
Conversation
…:FlowCrypt/flowcrypt-android into issue_2531_Migrate_to_Credential_Manager
DenBond7
changed the title
Collaborator
Author
|
Current changes cover only sign-in action for the UI interaction case. But still is no available way to get idToken silently. And many tests will be disabled after these changes. I prefer not to update this library yet. I will wait for more functionality. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR added a migration to the Credential Manager for Sign-in process
issue #2531
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):