Add granular RBAC SSO support#7733
Conversation
fixes #7396 Includes both SMAL and LDAP Also includes a fix for the direct SSO login buttons on login page
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7733 +/- ##
==========================================
+ Coverage 75.58% 75.61% +0.03%
==========================================
Files 432 432
Lines 22978 23035 +57
Branches 6091 6107 +16
==========================================
+ Hits 17367 17417 +50
- Misses 5611 5618 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
knolleary
left a comment
There was a problem hiding this comment.
I've done a first pass and spotted a couple things.
It would be helpful to have some more inline comments (similar to the existing code) to help make the logic more explicit.
I need to spend some more time testing it to verify the behaviour.
@knolleary fixed things based on first pass comments
|
@hardillb I've pushed a small update
I think it's good to go. Can you give that last commit a once over before merging? |
|
It failing one of the SSO SAML tests, will have a look at it in the morning |
|
@knolleary The new if block causes a test failure. Adding the if block means the test that removes an application override when the group is removed from the user doesn't fire if there are no other application overrides. The new if block needs removing |
|
If a user has any Application Group assignments in a Team then they can only be Group managed, but other users are free to be manually configured. You can't mix the 2 |
Revert if statement
|
I'm seeing some incorrect behaviour in my local testing.
|
|
I can see how that would happen, will work out how to fix |
|
@knolleary fix pushed |
|
We will need to regenerate the types if this merges after #7825 |
fixes #7396
Description
Includes both SMAL and LDAP
Also includes a fix for the direct SSO login buttons on login page
Related Issue(s)
#7396
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel