Split live-status tracking into its own subscriber (and share one MQTT connection) - Part 1: Add attachClient/detachClient#7843
Open
n-lark wants to merge 6 commits into
Open
Split live-status tracking into its own subscriber (and share one MQTT connection) - Part 1: Add attachClient/detachClient#7843n-lark wants to merge 6 commits into
attachClient/detachClient#7843n-lark wants to merge 6 commits into
Conversation
11 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7843 +/- ##
=======================================
Coverage 75.61% 75.61%
=======================================
Files 432 432
Lines 23035 23035
Branches 6107 6107
=======================================
Hits 17417 17417
Misses 5618 5618
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
cstns
requested changes
Jul 17, 2026
cstns
left a comment
Contributor
There was a problem hiding this comment.
Looking great! Please rename the attached to something more explicit
…Fuse/flowfuse into 7608-mqtt-shared-connection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
attachClient/detachClientto the MQTT service so multiple subscribers can share one connection per key. Reused while anyone's attached, torn down only when the last detaches.createClient/destroyClientare unchanged and nothing uses attach/detach yet.Related Issue(s)
Relates to #7608
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel