Skip to content

Fix link checker: check combined Nuxt+11ty output#5057

Open
Yndira-E wants to merge 1 commit into
mainfrom
yndira/fix-link-checker
Open

Fix link checker: check combined Nuxt+11ty output#5057
Yndira-E wants to merge 1 commit into
mainfrom
yndira/fix-link-checker

Conversation

@Yndira-E
Copy link
Copy Markdown
Contributor

@Yndira-E Yndira-E commented May 25, 2026

Summary

  • Adds untitaker/hyperlink to the website CI (test.yml) pointing to nuxt/.output/public/, which contains the full combined output of both 11ty and Nuxt pages
  • Previously, untitaker/hyperlink was removed in nuxt: privacy migration #4984 and replaced with nuxt-link-checker, but investigation showed nuxt-link-checker as configured only checks 2 pages (/terms and /privacy-policy) and skips links to 11ty pages entirely
  • This restores full link coverage across the entire site

Context

As part of the Nuxt migration, privacy-policy was moved to Nuxt, so it no longer exists in the 11ty _site/ output. This caused a false positive in the flowfuse repo CI (PR #7328) and led to the removal of untitaker/hyperlink from the website CI — leaving no effective link checking in place.

--sources only accepts a single value, so it's set to src/ (11ty sources). For broken links originating in Nuxt pages, the error will point to the generated HTML file in nuxt/.output/public/ rather than the source .vue file — but all broken links across the full site are still detected regardless.

Once the Nuxt migration is complete and all pages are served by Nuxt, we'll evaluate whether untitaker/hyperlink is still needed or can be replaced entirely by nuxt-link-checker.

Test plan

  • CI passes with 0 link errors on this PR
  • Intentionally breaking a link in a source file causes the check to fail

🤖 Generated with Claude Code

Runs untitaker/hyperlink against nuxt/.output/public/ which contains
the full combined output of both 11ty and Nuxt pages, replacing the
previous approach that only checked the 11ty _site/ output.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@Yndira-E Yndira-E marked this pull request as draft May 25, 2026 16:18
@netlify
Copy link
Copy Markdown

netlify Bot commented May 25, 2026

Deploy Preview for flowforge-website ready!

Name Link
🔨 Latest commit 4b31beb
🔍 Latest deploy log https://app.netlify.com/projects/flowforge-website/deploys/6a1475abdd37fe0008655da3
😎 Deploy Preview https://deploy-preview-5057--flowforge-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 83 (🔴 down 5 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@Yndira-E Yndira-E requested a review from ppawlowski May 25, 2026 16:24
@Yndira-E Yndira-E marked this pull request as ready for review May 25, 2026 16:24
@Yndira-E Yndira-E linked an issue May 25, 2026 that may be closed by this pull request
@Yndira-E Yndira-E requested a review from ZJvandeWeg May 25, 2026 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

All links to Privacy Policy look to be broken

1 participant