Migrate Custom Assistants to Agents#6163
Draft
HenryHengZJ wants to merge 27 commits intofeature/SmartAgentsfrom
Draft
Migrate Custom Assistants to Agents#6163HenryHengZJ wants to merge 27 commits intofeature/SmartAgentsfrom
HenryHengZJ wants to merge 27 commits intofeature/SmartAgentsfrom
Conversation
- Replace dual-table (assistant + chatflow) with single chatflow table for Agents. - Add /agents route as default landing page - Full configure page with dynamic field options from server node definitions - Dedicated agents RBAC permission group - Agent marketplace template type with view-only preview, type-validated export/import, and evaluation updates.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request rebrands "Custom Assistants" to "Agents" across the application, introducing a new "Agent" chatflow type and updating the UI, server logic, and database migrations accordingly. Key changes include the addition of an AgentListMenu component, new routes for agents, and updated RBAC permissions. Feedback focuses on fixing incorrect prop usage in CustomAssistantLayout.jsx, adding error handling for marketplace JSON parsing, implementing rollback logic in database migrations, and ensuring consistent permission naming.
HenryHengZJ
requested review from
0xi4o,
chloebyun-wd,
harshit-flowise,
jchui-wd and
yau-wd
…ents permission additions - Wrap all marketplace template JSON parsing in try-catch to prevent a single malformed file from crashing the entire marketplace - Remove incompatible AgentListMenu from legacy CustomAssistantLayout
Contributor
Author
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request rebrands "Custom Assistant" to "Agent" across the application, involving updates to UI components, routes, and menu items. Server-side logic and database migrations have been implemented to support the new AGENT chatflow type while maintaining backward compatibility for legacy ASSISTANT records. Additionally, "Chatflow Latency" is renamed to "Flow Latency" in evaluators, and validation has been added for flow file imports. Feedback was provided to avoid hardcoded hex colors in the new Agents view, recommending the use of theme-based colors for better consistency across different display modes.
…/github.com/FlowiseAI/Flowise into feature/Migrate-Custom-Assistants-to-Agents
* add compact table transformer for NotionAPILoader . * fix: improve table transformation logic in NotionAPILoader * fix: improve table transformation logic in NotionAPILoader * fix: improve table transformation logic in NotionAPILoader
add groq sdk
include action metadata from API responses
silent fallback to vm2 for sandbox execution
* feat(components): add Baidu Qianfan embeddings node * fix(components): preserve explicit numeric values in Baidu embeddings * Improve Qianfan embedding defaults and guidance
…y state (#6210) - Implemented auto-add functionality for Start node in Agentflow when creating a new canvas. - Updated default values for number and options types to return empty strings instead of zero or first option name. - Adjusted MessagesInput and ArrayInput tests to reflect changes in default values.
release@3.1.2 Co-authored-by: yau-wd <yau.ong@workday.com>
* fix(server): clickjacking * fix(XSS.ts): handle CSV and null values in getAllowedIframeOrigins
…Edge, and duplicateNode actions (#6211) * fix(agentflow): add onFlowChange notifications for deleteNode, deleteEdge, and duplicateNode actions - Updated context state management to include viewport information during flow changes. - Improved test coverage for flow change notifications to ensure correct behavior on node and edge modifications. * address gemini comment
… node (#6212) - Enhanced Start node to include a client property for the form input option, allowing differentiation between 'agentflowv2' and 'agentflowsdk'. - Added tests to verify that the 'formInput' option is correctly filtered based on the client type.
* feat: turn chatflow into MCP server - Added '@modelcontextprotocol/sdk' version 1.12.0 - Added 'zod' version 3.25.32 - Added migrations for MCP server config - Added MCP endpoints (Streamable HTTP and SSE) - Added MCP server configuration tab - Added unit tests for MCP endpoints and services * feat: Implement MCP endpoint service with SSE support - Added a new MCP endpoint service to handle requests for chatflows, including support for SSE (Server-Sent Events) and stateless transport. - Introduced functions for handling MCP requests, SSE connections, and message routing. - Implemented error handling for service errors and session management for SSE. - Created unit tests for the MCP server service, covering configuration CRUD operations and token management. - Updated the MCP server configuration logic to ensure proper validation and error handling. - Refactored the UI component to utilize a new API hook for fetching MCP server configuration. * chore: handle error when get mcp server config * - Introduced a new chat type 'MCP' in the ChatType enum, including UI filters and backend processing. - Updated the zod dependency version specification to support both ^3.25.76 and ^4. - Fix setHasExistingConfig * fix: update chatflowCallback to enable chatflow building with active state for MCP * refactor: remove deprecated SSE transport endpoints and related logic - Removed handleGet and handleSseMessage methods from MCP endpoint controller. - Updated MCP endpoint routes to eliminate SSE-related routes. - Refactored service layer to remove SSE session management and related methods. - Updated tests to remove references to deprecated SSE functionality. - Adjusted UI component to remove SSE endpoint URL handling. * chore: update MCP endpoint routes and references to align with new API structure * chore: remove abortChatMessage when mcp request closed * optimize mcpserver dialog for dark mode * feat: implement form input schema generation for agentflow chatflows --------- Co-authored-by: Henry <hzj94@hotmail.com>
…xt to validate (#6224) * feat(agentflow): optional cavasActions to allow additional buttons next to validate - Updated Agentflow component to support canvasActions prop for rendering additional action buttons in the canvas overlay. - Enhanced type definitions to include canvasActions in AgentflowProps. - Added tests to verify the rendering of canvasActions in the Agentflow component. - Added a new example demonstrating custom FABs alongside the validation button. * update jsdoc to match actual implementation
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* enhance ChatflowConfigurationDialog with new configuration sections and improved UI * fix: remove background color override for MuiSvgIcon in dark mode
# Conflicts: # packages/server/src/database/migrations/mariadb/index.ts # packages/server/src/database/migrations/mysql/index.ts # packages/server/src/database/migrations/postgres/index.ts # packages/server/src/database/migrations/sqlite/index.ts
- smartagents
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FLOWISE-457
Summary
/agentsroute as the default landing pagetype='AGENT'agentsRBAC permission group with DB migration via SQL REPLACE for production scaleagents_flowise.mp4
Key Changes
Architecture Simplification
getAllChatflows('AGENT')returns both legacy ASSISTANT and new AGENT type recordsUI — Agent Configure Page
Permissions
agentspermission group (view, create, update, duplicate, delete, export, import, config, domains)assistants:*→agents:*using SQL REPLACE (O(1) bulk, scales to millions)agents:*permission checksMarketplace
Agenttemplate type with dedicated filter chip/marketplace/agents/:id/agents/newwith fields populatedmarketplaces/agents/)Evaluations
Export/Import
typefield (CHATFLOW, AGENTFLOW, AGENT, MULTIAGENT)credentialandFLOWISE_CREDENTIAL_IDkeys)Execution Details
/agents/:idinstead of/v2/agentcanvas/:idTest plan
/agents/new→ configure → save → verify chatflow created with type AGENT"type": "AGENT"and no credentials/agents/newagentsgroup first, existing roles haveagents:*after migrationFollow up
zIndexissue on the chatembed side with the titlebar and modal pop up