fix: preserve metadata in RetrieverTool when using Custom Retriever#6243
Open
limbergarcia wants to merge 4 commits intoFlowiseAI:mainfrom
Open
fix: preserve metadata in RetrieverTool when using Custom Retriever#6243limbergarcia wants to merge 4 commits intoFlowiseAI:mainfrom
limbergarcia wants to merge 4 commits intoFlowiseAI:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the CustomRetriever class by delegating document retrieval to a new _getRelevantDocuments method and ensuring resultFormat defaults to a standard value. A review comment correctly identifies a potential issue where special replacement patterns in pageContent could cause unexpected behavior during string replacement, suggesting a functional approach to ensure literal interpretation.
…riever.ts Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛 Bug Description
When using Custom Retriever with Retriever Tool, metadata from vector store (e.g. Qdrant) is lost and only
pageContentis preserved.Root Cause
CustomRetriever overrides
getRelevantDocuments()and returns formatted documents, but RetrieverTool internally callsretriever.invoke(), which uses LangChain's_getRelevantDocuments()instead.This causes:
Fix
Updated CustomRetriever to ensure compatibility with LangChain's
invoke()flow and preserve metadata correctly.Steps to Reproduce
Qdrant → CustomRetriever → RetrieverTool → Agent
Expected Behavior
Metadata fields like:
should be preserved and accessible in the final output.
🔗 Related Issue
Closes #6242