Skip to content

fix untimed last word fixes #779 #812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pxeemo wants to merge 1 commit into from
Closed

fix untimed last word fixes #779 #812

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions app/src/main/java/org/akanework/gramophone/logic/utils/SemanticLyrics.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package org.akanework.gramophone.logic.utils

Check notice on line 1 in app/src/main/java/org/akanework/gramophone/logic/utils/SemanticLyrics.kt

View check run for this annotation

CodeScene Delta Analysis / CodeScene Code Health Review (beta)

✅ Getting better: Lines of Code in a Single File 

The lines of code decreases from 1111 to 1110, improve code health by reducing it to 600. The number of Lines of Code in a single file. More Lines of Code lowers the code health.

import android.os.Parcel
import android.os.Parcelable
Expand Down Expand Up @@ -682,8 +682,7 @@
}
val start = if (currentLine.isNotEmpty()) currentLine.first().first
else lastWordSyncPoint ?: lastSyncPoint!!
val end = lastWordSyncPoint ?:
words?.lastOrNull()?.timeRange?.last?.let { it - 1uL }
val end = words?.lastOrNull()?.timeRange?.last
// if we had trailing sync point only with whitespace line, it's explicit line
// end ts, use it.
// if we have words, use it's last sync point (possibly estimated) as end time,
Expand Down