Repository navigation
feat(scan): walking skeleton from page fetch to OSV-backed report (#8) - #27
Merged
Merged
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #8:
[S2] Walking skeleton: page fetch → header + Retire.js uri/filename fingerprint → OSV by purl → JSO…What and why
The platform made the commits and the branch from the files the agent handed back; it does not use the agent's own git state on the box, so anything the summary says about committing, branching or pushing describes only what the agent could do there.
The agent's summary, quoted:
The agent's decisions, and where it departed from the issue or the design, quoted:
Changes
cmd/touchstone/main.go— 83 linesgo.mod— 19 linesinternal/fingerprint/data/signatures.json— 14 linesinternal/fingerprint/fingerprint.go— 238 linesinternal/fingerprint/fingerprint_test.go— 138 linesinternal/service/scanner.go— 242 linesinternal/service/scanner_test.go— 227 linesinternal/vuln/osv.go— 166 linesinternal/vuln/osv_test.go— 122 linesinternal/vuln/testdata/osv/querybatch-jquery-1.12.4.json— 16 linesinternal/vuln/testdata/osv/vulns/GHSA-6c3j-c64m-qhgq.json— 13 linesinternal/vuln/testdata/osv/vulns/GHSA-gxr4-xjj5-5px2.json— 13 lines12 file(s) in all.
Acceptance, from the issue
`touchstone scan` against a fixture page that loads `jquery-1.12.4.min.js` reports jQuery 1.12.4 at Low confidence, with the script URL as evidence and at leas…— the agent says:Scanner test: fixture site loads jquery-1.12.4.min.js gives jQuery 1.12.4 LOW, script URL evidence, CVE-2020-11022 via recorded OSV. Not run against the compil…The report's `checked` list contains every request made, with its reason; `requests_used` matches— the agent says:Test checks checked = TARGET and SUBRESOURCE with reasons and results; requests_used equals len(checked); budget-refused script is recorded.OSV is called through `vuln.Source`; CI uses recorded OSV responses, no live network— the agent says:OSV goes through vuln.Source (vuln.OSV); tests replay recorded responses via httptest; no test makes a live network call.The items are the issue's own; each status is the agent's report, which the platform has not checked.
Checks
Review this like any other change. The agent ran on the member's own machine from the text of the issue; the platform has not built or tested it. CI results appear on this pull request.
passedHow this pull request was made
Opened by the platform from a coding agent's run on a member's box (run
f3674b00). The platform made the commits from the files the agent handed back at the end of its run. Nothing is merged automatically.