Fix API downloads ignoring ProxyDownload configuration#376
Closed
utafrali wants to merge 1 commit intoForceu:masterfrom
Closed
Fix API downloads ignoring ProxyDownload configuration#376utafrali wants to merge 1 commit intoForceu:masterfrom
utafrali wants to merge 1 commit intoForceu:masterfrom
Conversation
Owner
|
Thank you for the PR, however I am afraid that the issue already got fixed in a081d9b :/ |
Author
|
No worries, glad it's already taken care of. Closing this one out. |
Author
|
ah didn't see that commit, closing this |
Owner
|
Thank you very much anyway :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #375
API downloads were always being proxied regardless of the ProxyDownload configuration. The issue was that forceDecryption was checked before the ProxyDownload config, causing it to return early and never evaluate the setting.
Updated the logic to only force decryption when the file is actually encrypted (forceDecryption && file.Encryption.IsEncrypted). This lets the ProxyDownload configuration work as intended for API calls.
Added a test case that covers this scenario to make sure both paths work correctly.