Repository navigation
feat: allow nested condition tree - #2029
Merged
Merged
Conversation
2 new issues
|
|
Coverage Impact This PR will not change total coverage. Modified Files with Diff Coverage (2)
🛟 Help
|
arnaud-moncel
force-pushed
the
feat/nested-condition-tree
branch
from
November 2, 2026 10:32
a8321f0 to
fcaa8a3
Compare
christophebrun-forest
approved these changes
Nov 5, 2026
christophebrun-forest
left a comment
Member
There was a problem hiding this comment.
OK for me
Manual tests ok with server and front
forest-bot
added a commit
that referenced
this pull request
Nov 6, 2026
# @forestadmin/datasource-mongoose [1.15.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-mongoose@1.14.8...@forestadmin/datasource-mongoose@1.15.0) (2026-11-06) ### Features * allow nested condition tree ([#2029](#2029)) ([1417b5b](1417b5b))
forest-bot
added a commit
that referenced
this pull request
Nov 6, 2026
# @forestadmin/datasource-sequelize [1.14.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-sequelize@1.13.16...@forestadmin/datasource-sequelize@1.14.0) (2026-11-06) ### Features * allow nested condition tree ([#2029](#2029)) ([1417b5b](1417b5b))
forest-bot
added a commit
that referenced
this pull request
Nov 6, 2026
# @forestadmin/agent [1.113.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/agent@1.112.0...@forestadmin/agent@1.113.0) (2026-11-06) ### Features * allow nested condition tree ([#2029](#2029)) ([1417b5b](1417b5b))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Definition of Done
Fixes PRD-1171
General
Security
Note
Support nested condition trees and advertise
canUseNestedConditionTreecapabilityConditionTreeParser.fromPlainObjectnow uses a recursiveparsemethod so nested groups stay nested instead of being flattened. Empty root groups remain valid, but empty nested groups are rejected with a validation error.isLeafandisBranchguards no longer treatnullinput or non-arrayconditionsas valid shapes; these now hit the invalid-tree error path.FilterGenerator.computeMatchin filter.ts handles empty branches: an emptyOrproduces a match-none expression, and an emptyAndproduces no restriction.canUseNestedConditionTree: trueso clients can detect the new behavior.ValidationError(seeparsein condition-tree-parser.ts) or match differently for emptyOr/Andbranches.Changes since #2029 opened
ConditionTreeParser.fromPlainObjectcall inAuthorizationService.getScopein a try/catch block that throws anUnprocessableErrorwhen scope parsing fails. [e7d2070]Macroscope summarized fcaa8a3.