Repository navigation
Conversation
|
Coverage Impact This PR will not change total coverage. Modified Files with Diff Coverage (1)
🛟 Help
|
Tonours
force-pushed
the
fix/prd-1764-bind-signed-approval
branch
from
October 28, 2026 10:54
02b1d9d to
ba409f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Aligns action approval request handling with agent-nodejs and agent-python: an action run with an approval request uses the signed payload, scoped to the collection it was issued for.
fixes PRD-1764
What
routes/action/actions.rbdatais used as the action request data. Approval requests issued for another collection, without explicit record ids, with an unexpected shape, or that cannot be decoded return aForbiddenError(403) before permission checks.spec/.../routes/resources/action/actions_spec.rbspec/.../routes/action/actions_spec.rbspec/.../services/smart_action_checker_spec.rbWhy
valueskeep field-aware parsing (collection and file fields). The copy passed toSmartActionCheckeris adeep_dup, so the checker contract is unchanged.filters, search, segment) still apply on top of the signed selection, as in Node and Python.Parity: consistency follow-ups for the other agents are tracked internally.
How to test
cd packages/forest_admin_agent && BUNDLE_GEMFILE=Gemfile-test bundle exec rspec spec/lib/forest_admin_agent/routes/action spec/lib/forest_admin_agent/routes/resources/action spec/lib/forest_admin_agent/services/smart_action_checker_spec.rb spec/lib/forest_admin_agent/services/permissions_spec.rb: 133 examples, 0 failures.Definition of Done
General
Security
https://claude.ai/code/session_01TVjvko66LLq8rEjEqNokRA