fix(core): unscored reason names each cause once; CI checks formatting - #57
Merged
Conversation
…ting `rendered-body` and `sample-adequate` both say "The scan fetched no pages." when nothing was fetched, and the orchestrator joined every reason as-is. `unjudgeableReason` dedupes in key order. CI runs `pnpm format:check` after lint, so the drift #55 removed cannot return unseen. Claude-Session: https://claude.ai/code/session_01RT21vyEPL6uSMWwUTytw6p
A failed fetch is a result the caller reads, not a fault, so the fetcher warns in one line and keeps the error object for debug. vitest runs at LOG_LEVEL=error unless told otherwise, and the live verification suite's "full results" dumps are opt-in via AL_VERIFY_VERBOSE. A green CI run printed thousands of lines of stack frames and pass lists before this. Claude-Session: https://claude.ai/code/session_01RT21vyEPL6uSMWwUTytw6p
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small fixes before the 4.0.0 release.
rendered-bodyandsample-adequateboth say "The scan fetched no pages." when nothing was fetched, and the orchestrator joined every reason as-is, so every walled site read "The scan fetched no pages. The scan fetched no pages."unjudgeableReasoninpackages/core/src/scan-evidence.tsdedupes in key order. Two tests, patch changeset.pnpm format:checkafter lint, so the drift chore: bring the repo under Prettier 3.9.6; archive the corpus spec #55 removed cannot come back unseen.The scan wall-clock budget is tracked in #56 and stays out of this release.
Gate
pnpm build && pnpm test && pnpm typecheck && pnpm lint && pnpm check:dossiers && pnpm check:requires && pnpm check:audit-map && pnpm format:checkgreen: 5329 tests.https://claude.ai/code/session_01RT21vyEPL6uSMWwUTytw6p