Write NetCDF files and call VULCAN robustly [DO NOT REVIEW YET]#775
Draft
nichollsh wants to merge 13 commits into
Draft
Write NetCDF files and call VULCAN robustly [DO NOT REVIEW YET]#775nichollsh wants to merge 13 commits into
nichollsh wants to merge 13 commits into
Conversation
… deprecated 'seed' with 'rng' parameter for Halton sequence.
…y met. Combines this into a dedicated function to check when to write. Also, always writes final NetCDF file. Align JANUS and AGNI writing filename format to use %.0f. Also, since previously JANUS wrote every iteration, now performs same write-gating-check between AGNI and JANUS. Ensures that offline chemistry doesn't crash on missing NetCDF. Add tests to cover NetCDF writing behaviour. Updates configs and docstrings. Updates chemistry plot after running offchem.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #775 +/- ##
==========================================
+ Coverage 92.66% 92.71% +0.04%
==========================================
Files 110 110
Lines 15807 15867 +60
Branches 2846 2855 +9
==========================================
+ Hits 14648 14711 +63
+ Misses 1159 1148 -11
- Partials 0 8 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces a few different improvements and fixes.
Robust Atmospheric Data Handling
find_latest_atmosphere_timeincommon.pyto locate the most recent available atmosphere NetCDF snapshot, and updatedrun_vulcaninvulcan.py. Improving resilience to missing files.write_atmos_ncdfhelper functions for writing NetCDF filesOutput Writing and Configuration
dt_write_relparameter in documentation and config fileswrite_modvia logical OR, rather than logical AND.Chemistry Model
Validation of changes
Outline your test configuration; e.g. MacOS with Python 3.13.
Checklist