Skip to content

Write NetCDF files and call VULCAN robustly [DO NOT REVIEW YET]#775

Draft
nichollsh wants to merge 13 commits into
mainfrom
hn/writencdf
Draft

Write NetCDF files and call VULCAN robustly [DO NOT REVIEW YET]#775
nichollsh wants to merge 13 commits into
mainfrom
hn/writencdf

Conversation

@nichollsh

Copy link
Copy Markdown
Member

Description

This pull request introduces a few different improvements and fixes.

Robust Atmospheric Data Handling

Output Writing and Configuration

  • Clarified the meaning of dt_write_rel parameter in documentation and config files
  • Now actsas an additional time-based write trigger combined with write_mod via logical OR, rather than logical AND.

Chemistry Model

Validation of changes

  • More tests

Outline your test configuration; e.g. MacOS with Python 3.13.

Checklist

  • I have followed the contributing guidelines
  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • My changes generate no new warnings or errors
  • I have checked that the tests still pass on my computer
  • I have updated the docs, as appropriate
  • I have added tests for these changes, as appropriate
  • I have checked that all dependencies have been updated, as required

nichollsh added 13 commits June 17, 2026 13:54
… deprecated 'seed' with 'rng' parameter for Halton sequence.
…y met. Combines this into a dedicated function to check when to write. Also, always writes final NetCDF file. Align JANUS and AGNI writing filename format to use %.0f. Also, since previously JANUS wrote every iteration, now performs same write-gating-check between AGNI and JANUS. Ensures that offline chemistry doesn't crash on missing NetCDF. Add tests to cover NetCDF writing behaviour. Updates configs and docstrings. Updates chemistry plot after running offchem.
@nichollsh nichollsh changed the title Hn/writencdf Write NetCDF files and call VULCAN robustly [DO NOT REVIEW YET] Jul 23, 2026
@codecov

codecov Bot commented Jul 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.33333% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.71%. Comparing base (9881061) to head (73872ac).

Files with missing lines Patch % Lines
src/proteus/atmos_clim/janus.py 33.33% 6 Missing ⚠️
src/proteus/proteus.py 50.00% 3 Missing ⚠️
src/proteus/utils/coupler.py 66.66% 0 Missing and 3 partials ⚠️
src/proteus/atmos_chem/vulcan.py 94.11% 0 Missing and 1 partial ⚠️
src/proteus/atmos_clim/wrapper.py 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #775      +/-   ##
==========================================
+ Coverage   92.66%   92.71%   +0.04%     
==========================================
  Files         110      110              
  Lines       15807    15867      +60     
  Branches     2846     2855       +9     
==========================================
+ Hits        14648    14711      +63     
+ Misses       1159     1148      -11     
- Partials        0        8       +8     
Flag Coverage Δ
unit-tests 83.69% <83.33%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant