Percentual (%) operations not saved in history

[BrendonIrwan]

Checklist

• I can reproduce the bug with the latest version given here.
• I made sure that there are no existing issues - open or closed - to which I could contribute my information.
• I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
• I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
• I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
• This issue contains only one bug.
• I have read and understood the contribution guidelines.

Affected app version

1.4.0

Affected Android/Custom ROM version

Agnostic, multiple

Affected device model

Agnostic, multiple

How did you install the app?

F-Droid / IzzyOnDroid

Steps to reproduce the bug

1. AC (hold down C)
2. 8 5 × 2 5 %
3. Immediately results to 21.25 (correct)
4. Check history

Feel free to do any other percentual operations other than the above.

Expected behavior

Operation shows in history.

Actual behavior

Operation missing in history (not saved).

Screenshots/Screen recordings

Trivial. No need.

Additional information

If the history was empty, then it remains empty after said operation. Thus it isn't a visual issue.

History already works outside of the evaluate button =, e.g. try doing multiple additions in succession like 1 + 2 + 3. So I suspect it's just an oversight of event attachment.

[BrendonIrwan]

In app/src/main/kotlin/org/fossify/math/helpers/CalculatorImpl.kt, the history is only updated in calculateResult() which isn't used for percentual operations. Instead, it is handled in calculatePercentage() via handlePercent().

Line 115 is where they begin to split.

The solution should be trivial but I suggest refactoring to clarify the flow.

EDIT: Corrected function name typo, my apologies.