Release 1.9.7.3 AntiFlood settings, debug logging, mod management overhaul, and community fixes#266
Open
jupster wants to merge 28 commits into
Open
Release 1.9.7.3 AntiFlood settings, debug logging, mod management overhaul, and community fixes#266jupster wants to merge 28 commits into
jupster wants to merge 28 commits into
Conversation
…alization (#115, #131, #167, #238, #242, #251, #254, #255, #259) FASTER/Models/ArmaMod.cs, FASTER/Models/SteamWebApi.cs - #167: Show one-time warning after 3 failed retries if Steam API Key is invalid; check response.IsSuccessStatusCode in ApiCall() so errors propagate to retry logic with a meaningful reason FASTER/Models/BasicCfg.cs - #251/#115: PerfPreset getter always returns "Custom" so JSON deserialization called the setter and reset MaxMsgSend to 256 on every profile clone; fixed with [Newtonsoft.Json.JsonIgnore] FASTER/ViewModel/DeploymentViewModel.cs - #254: LinkMod/DeleteLink called Directory.Delete(path, true) on symlinks, which destroyed the source mod folder; now checks FileAttributes.ReparsePoint - #131: DeployAll() crashed when InstallPath didn't exist; added guard + user-facing error message; added UnauthorizedAccessException handler with Developer Mode / run-as-Admin guidance FASTER/ViewModel/SteamUpdaterViewModel.cs - #242: mod.Status was set to NotComplete in the early cancellation path before any download started - #259: Task.Factory.StartNew(async ()=>) returns Task<Task>; missing .Unwrap() caused ContinueWith to fire instantly instead of after async work; converted lambda to async + await, added .Unwrap() - #238: NullReferenceException accessing SteamClient.Credentials.Username after SteamClient was nulled; save username before disposal Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
FASTER/Models/ServerCfg.cs - #246: Wrap LogObjectNotFound, SkipDescriptionParsing, ignoreMissionLoadErrors inside a class AdvancedOptions { }; block in server.cfg output FASTER/Models/BasicCfg.cs - #230: Add configurable language setting (default "English") with RaisePropertyChanged; replace hardcoded language="English" in ProcessFile() FASTER/Models/ServerProfile.cs - #231: Add HugePages (bool), BePath (string), ExThreads (int 0-7), LoadMissionToMemory (bool), LimitFPS (int), EnableSteamLogs (bool) properties with conditional inclusion in GetCommandLine() FASTER/ViewModel/ProfileViewModel.cs - #230: Expose Languages observable collection from BasicCfgArrays - #231: Add SelectBePath() folder picker FASTER/Views/Profile.xaml, FASTER/Views/Profile.xaml.cs - #230: Language ComboBox in Performance tab - #231: Controls for HugePages, BePath, ExThreads, LoadMissionToMemory, LimitFPS, EnableSteamLogs FASTER/ViewModel/ModsViewModel.cs, FASTER/Views/Mods.xaml, FASTER/Views/Mods.xaml.cs - #198: Add PurgeAndReinstallMod(), PurgeAndReinstallSelectedMods(), PurgeAndReinstallAll() — delete mod folder and mark for re-download - #258: Make CheckForUpdates() async with 300ms delay between mods to avoid Steam rate limiting Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…reorder, purge unused mods (#209, #216, #217, #229, #241) FASTER/Models/ServerCfg.cs - #217: Add AntiFlood settings block (enabled, cycleTime, cycleLimit, cycleHardLimit, enableKick) output in server.cfg under class AntiFlood {} - #229: Add missionHTTPDownloadBaseURL setting with conditional output FASTER/Models/ServerProfile.cs - #241: Add KeysFolder property with -keysFolder="..." in GetCommandLine() - #216: Add MoveProfileUp()/MoveProfileDown() for profile list reordering FASTER/ViewModel/ProfileViewModel.cs - #241: Add SelectKeysFolder() folder picker FASTER/Views/Profile.xaml, FASTER/Views/Profile.xaml.cs - #217: AntiFlood Expander with CheckBox + 3 NumericUpDowns + kick CheckBox - #229: TextBox for MissionHTTPDownloadBaseURL in missions section - #241: KeysFolder TextBox + folder browse button FASTER/MainWindow.xaml.cs - #216: Wrap each profile toggle in a DockPanel with ▲/▼ reorder buttons; add GetProfileToggleButtons() and GetSelectedProfileToggleButton() helpers FASTER/ViewModel/ModsViewModel.cs, FASTER/Views/Mods.xaml, FASTER/Views/Mods.xaml.cs - #209: Add PurgeUnusedMods() — cross-reference all profiles, prompt confirmation, delete mod folders not referenced by any profile Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
FASTER/Models/Logger.cs (new) - Static Logger class: writes timestamped entries to %AppData%\FASTER\faster.log when enableDebugLog setting is true FASTER/Properties/Settings.settings, FASTER/Properties/Settings.Designer.cs - Add enableDebugLog boolean setting (default: false) FASTER/Views/Settings.xaml, FASTER/Views/Settings.xaml.cs - Add "Enable Debug Logging" checkbox and "Open Log File" button in the Program Settings panel FASTER/ViewModel/ModsViewModel.cs - Log calls in CheckForUpdates (per-mod), PurgeAndReinstallMod (path + delete result), PurgeAndReinstallAll (staging dir, each deleted folder, each reset mod) FASTER/ViewModel/DeploymentViewModel.cs - Log calls in DeployAll (install path, each mod link), LinkMod (symlink creation, reparse point check, errors with detail) FASTER/ViewModel/SteamUpdaterViewModel.cs - Log calls in SteamLogin (each step, errors with stack trace), RunModsUpdater (login result, per-mod task start/end), DownloadForMultiple (SetupAsync/VerifyAsync/DownloadAsync steps, file verification events, exceptions with full stack traces) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…se (#239) .github/workflows/codeql-analysis.yml, .github/workflows/release.yml - #239: Add missing DOTNET_VERSION: '8.0.x' env var (was referenced by actions/setup-dotnet but never defined, causing workflow failures) .github/workflows/build.yml (new) - Add standalone build workflow that triggers on push/PR to master for fast build verification without depending on CodeQL .github/workflows/release.yml - Add permissions: contents: write to release job (required for GITHUB_TOKEN to create releases on forks) - Replace unmaintained andelf/nightly-release@main with softprops/action-gh-release@v2 - Add pre-step to delete existing nightly release + tag before recreating - Handle empty changelog gracefully (exit 0 instead of exit 1 when no tags) - Truncate changelog to 20k chars to avoid env var size limit (32766 max) global.json - Change rollForward from latestFeature to latestMajor so builds succeed with .NET SDK versions newer than 8.0.0 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
SonarCloud rule S2696 flags writing to static fields from instance methods. Extracted _apiKeyWarningShown write into TryShowApiKeyWarning() static method so the field is only accessed from static context. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
FASTER/Models/ServerProfile.cs - S2365: FilteredProfileMods returned new List<>(_profileMods) copying the collection; changed return type to IReadOnlyList<ProfileMod> and return _profileMods.AsReadOnly() to avoid the copy FASTER/Views/Mods.xaml.cs - CS8602/SonarCloud: await on nullable Task (from ?. operator) can throw NullReferenceException when DataContext is null; replaced with 'if (DataContext is ModsViewModel vm) await vm.Method()' pattern for CheckForUpdates_Click, PurgeAndReinstallAll_Click, PurgeUnusedMods_Click Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ash logging FASTER/Models/SteamWebApi.cs - S2699: Replace throw new Exception() with throw new HttpRequestException() so callers can catch a specific type instead of base Exception FASTER/ViewModel/SteamUpdaterViewModel.cs - S3776: Extract inner async lambda from RunModsUpdater into ProcessModDownloadAsync(ArmaMod mod) private method, reducing cognitive complexity from 36 to well below the 25 limit FASTER/App.xaml.cs - Add AppDomain.UnhandledException, DispatcherUnhandledException and TaskScheduler.UnobservedTaskException handlers that write to the debug log file — captures silent fatal crashes (e.g. native exceptions from BytexDigital.Steam during DownloadAsync) that bypass try/catch Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Fix for Performance preset for server profiles not copied over
#PR1 bug fixes
#PR2 Community-PRs
#PR3 Features
#PR4 Debug Logging
#PR5 CI/CD
Outer try block had no catch/finally and referenced an out-of-scope `ex` variable. Replaced the stray IsAnonymous check with a proper catch block to restore error logging without changing other logic.
jupster
added
bug
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jupster
commented
Jul 17, 2026
jupster
left a comment
jupster
left a comment
Collaborator
Author
There was a problem hiding this comment.
Self-review: Went through this PR end-to-end alongside a thorough line-by-line pass on the diffs, plus manual build/run testing on the fixes that touched compile-critical code (SteamDiagLogger, RunModsUpdater).
There are a handful of warnings present, but none are huge. most of them predate this branch and don't block the build or affect runtime behavior. Nothing in this PR introduces warnings or regressions that I've seen and am worried about at this point.
Happy to address feedback if anyone spots something in review. Flagging this as ready for others to take a look.
Update NumericUpDown for Profile.LimitFPS: change watermark to "-limitFPS (30=Default, max 999)" and set Minimum from 0 to 30. This enforces a 30 FPS minimum (Arma Default) and updates the UI hint to reflect the new default while keeping Maximum at 999.
Collaborator
Author
Remove a stray empty line at the top of FASTER.sln so the 'Microsoft Visual Studio Solution File, Format Version 12.00' header follows the file BOM on the first line. Purely cosmetic cleanup with no functional changes.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This release brings AntiFlood server configuration, an in-app debug logging system, mod purge/reinstall tooling, several critical bug fixes, and integrates a number of community-contributed pull requests.
Motivation and Context
Consolidates a large batch of accumulated improvements on the
feature/Update-1.9branch, including fixes for symlink handling, async deadlocks, and NullReferenceExceptions that could affect mod downloads and deployment, alongside new profile settings requested by the community.How Has This Been Tested?
Built and run locally via Visual Studio; manually verified mod purge/reinstall flows, AntiFlood settings persistence, debug log toggle and log file viewer, and Performance tab scrolling. CI build/CodeQL workflows updated and passing.
Screenshots (if appropriate):
Types of changes
Checklist:
Highlights
Community contributions
Includes and integrates PRs #198, #230, #231, #246, #252, #258, #261, #262, #263, #264, #265
Huge thanks to @diaversoand @YetheSamartaka