Conversation
VidgarVii
suggested changes
Jul 20, 2021
lib/simpler/middleware/logger.rb
Outdated
| private | ||
|
|
||
| def create_log | ||
| [@status, @header, @body] |
There was a problem hiding this comment.
какую функцию выполняет этот массив? если его удалить, по не сломается. А код станет не много чище
| Parameters: #{@request.params} | ||
| Response: #{full_status} \[#{@header["Content-Type"]}\] #{view} | ||
| ) | ||
| end |
There was a problem hiding this comment.
так как лог файл может быть беконечно большим, то лог каждого запроса лучше писать в 1 строчку
log/app.log
Outdated
| Handler: TestsController#question | ||
| Parameters: {"one"=>"1", :id=>"487", :question_id=>"25"} | ||
| Response: 200 OK [text/plain] | ||
|
|
There was a problem hiding this comment.
лучше не класть лог файл в репозиторий
VidgarVii
reviewed
Jul 21, 2021
| def index | ||
| @time = Time.now | ||
| render "tests/index" | ||
| end |
There was a problem hiding this comment.
согласно REST данный экшен должен отдавать список тестов, а не время
| def create | ||
| status 201 | ||
| render plain: "Create method in action!" | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.