Repository navigation
fix(testaudit): validate statistical detector configuration - #15
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StatisticalDetectoraccepted threshold settings without validating their range or ordering. Invalid configurations could make the pass/fail anomaly rules ambiguous, andmin_cohort_size=0allowed an empty cohort to reach division by zero.This change validates that both thresholds are between 0 and 1, that the universal-fail threshold is strictly lower than the universal-pass threshold, and that the minimum cohort size is a positive integer. Regression tests cover out-of-range values, overlapping thresholds, NaN thresholds, and invalid cohort sizes.
Validation