Skip to content

egl: preserve caller state and support surfaceless offscreen contexts - #12

Merged
tritao merged 2 commits into
freecad-masterfrom
stack/egl-offscreen
Sep 1, 2026
Merged

egl: preserve caller state and support surfaceless offscreen contexts#12
tritao merged 2 commits into
freecad-masterfrom
stack/egl-offscreen

Conversation

@tritao

@tritao tritao commented Aug 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

Make Coin's offscreen EGL handling safe for applications that already own EGL state and usable in surfaceless environments.

  • Support explicit surfaceless EGL through EGL_PLATFORM=surfaceless.
  • Reuse an active caller display when appropriate.
  • Distinguish borrowed EGL displays from Coin-owned displays.
  • Preserve and restore the client API, display, context, draw surface, and read surface.
  • Support optional core-profile offscreen contexts through COIN_EGL_CORE_PROFILE=1.
  • Add focused EGL context-preservation and surfaceless runtime coverage.

The old Wayland/X11 display-probing fallback is intentionally not restored. Coin honors an explicit surfaceless request, reuses active EGL state when possible, and otherwise follows the normal EGL default-display path.

Stack position

Builds on #11.

Patch Set

Important

This PR is part of a stacked series (1/27) and depends on freecad-master (the PR base branch). Review/merge in order.

  • Base: freecad-master
  • PR base (depends-on): freecad-master
  • Stack: 1/27
  • Range: upstream/freecad-master..63706367d2

Commits

  • 63706367d: tests: cover EGL context preservation
  • 708979fa9: egl: preserve caller state and support surfaceless contexts

@tritao tritao changed the title stack/egl offscreen egl: support robust surfaceless offscreen contexts Aug 8, 2026
@tritao tritao mentioned this pull request Aug 8, 2026
Closed
@tritao
tritao force-pushed the stack/egl-offscreen branch from 4878add to e9df85a Compare August 8, 2026 00:17
@tritao tritao mentioned this pull request Aug 8, 2026
Merged
@tritao
tritao force-pushed the stack/egl-offscreen branch from e9df85a to bb6f227 Compare August 8, 2026 01:07
@tritao tritao changed the title egl: support robust surfaceless offscreen contexts egl: preserve caller state in offscreen contexts Aug 8, 2026
@tritao tritao changed the title egl: preserve caller state in offscreen contexts egl: preserve caller state and support surfaceless offscreen contexts Aug 8, 2026
@tritao
tritao force-pushed the stack/egl-offscreen branch 2 times, most recently from 9b41184 to 8047ff9 Compare August 8, 2026 01:30
@tritao
tritao marked this pull request as ready for review August 8, 2026 01:30
@tritao
tritao force-pushed the stack/egl-offscreen branch from 8047ff9 to 184b81f Compare August 8, 2026 11:06
@tritao
tritao force-pushed the stack/egl-offscreen branch from 184b81f to 397fd05 Compare August 8, 2026 11:41
@tritao
tritao force-pushed the stack/egl-offscreen branch from 397fd05 to c31eb53 Compare August 8, 2026 12:06
@tritao
tritao force-pushed the stack/egl-offscreen branch 2 times, most recently from a9bb1ec to b12d484 Compare August 8, 2026 20:31
@tritao
tritao force-pushed the stack/egl-offscreen branch 3 times, most recently from a9181d5 to 5abded1 Compare August 9, 2026 02:34
@tritao
tritao force-pushed the stack/egl-offscreen branch 3 times, most recently from bae652a to e0605fd Compare August 9, 2026 11:44
@tritao
tritao force-pushed the stack/egl-offscreen branch from e0605fd to 1da471f Compare August 9, 2026 14:55
@tritao
tritao force-pushed the stack/egl-offscreen branch from 1da471f to 40f9511 Compare August 9, 2026 15:10
@tritao
tritao force-pushed the stack/egl-offscreen branch from 910dcff to cfb34e8 Compare August 19, 2026 01:34
Lgt2x
Lgt2x reviewed Aug 19, 2026
View reviewed changes
Comment thread .github/workflows/continuous-integration-workflow.yml Outdated
Comment thread src/glue/gl_egl.cpp Outdated
Comment thread testsuite/EGLBindingTest.cpp Outdated
Comment thread testsuite/CMakeLists.txt Outdated
Comment thread testsuite/EGLBindingTest.cpp Outdated
Comment thread testsuite/EGLBindingTest.cpp Outdated
@tritao
tritao force-pushed the stack/egl-offscreen branch 2 times, most recently from 1bb0941 to 36d8662 Compare August 19, 2026 10:28
@tritao
tritao force-pushed the stack/egl-offscreen branch from 36d8662 to 84c1f16 Compare August 19, 2026 11:15
@tritao

tritao commented Aug 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Addressed the EGL review feedback:

  • Integrated coverage into the existing Ubuntu job with Mesa EGL; no separate or core-only build.

  • Scoped EGLBindingTest to Linux.

  • Removed redundant void syntax and local constants provided by eglext.h.

  • Added shared skip-code handling and coin_add_egl_test().

  • Registered the test as egl;requires-egl.

  • Split coverage into two clear cases:

    • Coin acquires and owns an explicitly requested surfaceless display.
    • Coin borrows an active caller display and restores its complete EGL binding.

@tritao
tritao force-pushed the stack/egl-offscreen branch 5 times, most recently from 56d7cf8 to 5412d16 Compare August 19, 2026 13:56
@tritao
tritao force-pushed the stack/egl-offscreen branch 3 times, most recently from 9147da5 to 01e0c33 Compare August 23, 2026 11:13
@Lgt2x

Lgt2x commented Aug 28, 2026

Copy link
Copy Markdown
Member

I don't see the feedback comments addressed in the diff, did a push go wrong?

Base automatically changed from stack/gl-foundation to freecad-master August 28, 2026 20:46
@tritao
tritao force-pushed the stack/egl-offscreen branch from 01e0c33 to ffcf4b2 Compare August 28, 2026 20:50
@tritao

tritao commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator Author

I don't see the feedback comments addressed in the diff, did a push go wrong?

The commits were accidentally displaced and have now been restored. This is now ready for re-review.

@tritao

tritao commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator Author

@Lgt2x Ping

@tritao
tritao force-pushed the stack/egl-offscreen branch from ffcf4b2 to 6370636 Compare September 1, 2026 19:04
Lgt2x
Lgt2x approved these changes Sep 1, 2026
View reviewed changes

@Lgt2x Lgt2x left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now!

Comment thread testsuite/CMakeLists.txt
endif()
set_tests_properties(${ARG_NAME} PROPERTIES
SKIP_RETURN_CODE ${COIN_TEST_SKIP_RETURN_CODE}
LABELS "${test_labels}")

@Lgt2x Lgt2x Sep 1, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a label used for a single test has very little purpose

@tritao tritao Sep 1, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be used by subsequent stack layers, to run subset of EGL tests, so I'd rather keep it here.

@tritao
tritao merged commit df9b468 into freecad-master Sep 1, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lgt2x Lgt2x Lgt2x approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tritao @Lgt2x