Fix: Auto-add dtls_auto_generate_cert for DTLS media_encryption endpoints#186
Open
harrybirdnz wants to merge 1 commit intoFreePBX:release/17.0from
Open
Fix: Auto-add dtls_auto_generate_cert for DTLS media_encryption endpoints#186harrybirdnz wants to merge 1 commit intoFreePBX:release/17.0from
harrybirdnz wants to merge 1 commit intoFreePBX:release/17.0from
Conversation
…endpoints When a PJSIP endpoint is configured with media_encryption=dtls (required for WebRTC), Asterisk needs dtls_auto_generate_cert=yes and dtls_setup=actpass to successfully negotiate DTLS-SRTP. Without these lines, WebRTC calls fail with 'Couldn't negotiate stream' errors. This patch automatically appends the required DTLS parameters whenever media_encryption is set to 'dtls', ensuring WebRTC extensions work out of the box without manual custom_post.conf entries.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a PJSIP endpoint is configured with
media_encryption=dtls(required for WebRTC), Asterisk needsdtls_auto_generate_cert=yesanddtls_setup=actpassto successfully negotiate DTLS-SRTP. Without these lines, WebRTC calls fail with "Couldn't negotiate stream" errors.This patch automatically appends the required DTLS parameters whenever
media_encryptionis set todtls, ensuring WebRTC extensions work out of the box without manualcustom_post.confentries.Changes:
functions.inc/drivers/PJSip.class.php: adddtls_auto_generate_cert=yesanddtls_setup=actpasswhenmedia_encryption === 'dtls'