Skip to content

Improved Change Passwd by adding Gateway Passwd#1694

Open
Benouch wants to merge 1 commit into
FreeRDP:masterfrom
Benouch:Change-Password-Including-Gateway
Open

Improved Change Passwd by adding Gateway Passwd#1694
Benouch wants to merge 1 commit into
FreeRDP:masterfrom
Benouch:Change-Password-Including-Gateway

Conversation

@Benouch

@Benouch Benouch commented Aug 31, 2022

Copy link
Copy Markdown

Hi there,
I've improved on the change password feature of Remmina.
I've added the ability to also change the Gateway Password in mass.
I don't know if this has ever been requested but for me it is an essential feature since I use Remmina for a professional purpose and of course my password changes every so often. And since I use a RD Gateway to connect to Windows servers changing my Gateway password had become a chore.
I've haven't created any translations for the new labels. I'll be happy to do it for languages I know.
Thank you.
FYI it's my first pull/merge request so let me know if what I'm doing is correct.

image

@giox069

giox069 commented Aug 31, 2022

Copy link
Copy Markdown
Contributor

Hi @Benouch , your patch is very interesting. But this github repository is only a secondary mirror of the main gitlab repository here: https://gitlab.com/Remmina/Remmina/
Could you please create the same MR in GitLab ?

Thank you.

@Benouch

Benouch commented Aug 31, 2022 via email

Copy link
Copy Markdown
Author

@Benouch

Benouch commented Aug 31, 2022 via email

Copy link
Copy Markdown
Author

@antenore

Copy link
Copy Markdown
Member

I believe I recreated the exact same thing on gitlab. Let me know if anything.

On Wed, Aug 31, 2022 at 3:59 PM Giovanni Panozzo @.> wrote: Hi @Benouch https://github.com/Benouch , your patch is very interesting. But this github repository is only a secondary mirror of the main gitlab repository here: https://gitlab.com/Remmina/Remmina/ Could you please create the same MR in GitLab ? Thank you. — Reply to this email directly, view it on GitHub <#1694 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA6XV3N4643HVW3JS3C6Y7DV362RJANCNFSM6AAAAAAQBV4GIU . You are receiving this because you were mentioned.Message ID: @.>

We don't see it, can you please link the merge request?

@Benouch

Benouch commented Sep 1, 2022 via email

Copy link
Copy Markdown
Author

@antenore

antenore commented Sep 1, 2022

Copy link
Copy Markdown
Member

This is in your fork, you must submit a new MR at https://gitlab.com/Remmina/Remmina/-/merge_requests/new

@Benouch

Benouch commented Sep 1, 2022 via email

Copy link
Copy Markdown
Author

@giox069

giox069 commented Sep 1, 2022

Copy link
Copy Markdown
Contributor

If I'm not wrong, the correct procedure should be:

  1. In gitlab.com fork the main Remmina repository to your personal repository (and you already did it one time, I think)
  2. In your personal repository on gitlab create a new branch and add your code to this new branch
  3. Create a Merge Request from your repo/branch to the master branch of remmina repository (all in Gitlab)

@Benouch

Benouch commented Sep 1, 2022 via email

Copy link
Copy Markdown
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants