Fix RP2040 task lock acquire ordering#1440
Open
Old-Ding wants to merge 1 commit into
Open
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Fixes #1430.
vPortRecursiveLock()usedspin_try_lock_unsafe()for the uncontended RP2040 task/ISR lock path, then immediately read lock-protected bookkeeping. The blocking path already gets acquire ordering fromspin_lock_unsafe_blocking(), but the successful try-lock path did not.This adds an acquire fence only on the try-lock success path. The contended path is left unchanged so it does not receive a duplicate fence.
Test Steps
portable/ThirdParty/GCC/RP2040/include/portmacro.h.spin_lock_unsafe_blocking()/spin_try_lock_unsafe()definitions to confirm only the try-lock fast path lacks acquire ordering.git diff HEAD~1 HEAD --check.Not run: RP2040 hardware build/runtime test; the local Windows environment does not have
cmakeorarm-none-eabi-gccinstalled.Checklist:
Related Issue
#1430
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.