Fix vPortFreeSecureContext to read xSecureContext at correct offset#1441
Draft
aggarg wants to merge 1 commit into
Draft
Fix vPortFreeSecureContext to read xSecureContext at correct offset#1441aggarg wants to merge 1 commit into
aggarg wants to merge 1 commit into
Conversation
When MPU is enabled, the first item in the TCB is not the top of the stack but the stored context location. As a result, xSecureContext is located at a negative offset from that position rather than at offset 0. The current implementation unconditionally reads xSecureContext at offset 0, which returns an incorrect value when MPU is enabled. This commit updates vPortFreeSecureContext to read xSecureContext at the correcct offset based on the port configuration: - CM33/CM35P/CM52/CM55/CM85/STAR_MC3: -20 (or -36 with PAC enabled) - CM23: -20 (no PAC support) - Without MPU: 0 (xSecureContext remains at the top of stack) Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When MPU is enabled, the first item in the TCB is not the top of the stack but the stored context location. As a result,
xSecureContextis located at a negative offset from that position rather than at offset 0. The current implementation unconditionally readsxSecureContextat offset 0, which returns an incorrect value when MPU is enabled.This commit updates
vPortFreeSecureContextto readxSecureContextat the correct offset based on the port configuration:xSecureContextremains at the top of stack)Test Steps
Tested using CORTEX_MPU_M33F_Nordic_NRF9160_SES demo.
Checklist:
Related Issue
NA
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.