[codex] fix MicroBlaze stack protection context layout#1442
Open
Old-Ding wants to merge 1 commit into
Open
Conversation
1ca0d4b to
e84e83c
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Fixes #1416.
This updates the MicroBlazeV9 assembly context layout so
XPAR_MICROBLAZE_USE_STACK_PROTECTIONhas valid save/restore slots for the stack limit registers:portSLR_OFFSETandportSHR_OFFSETfor 32-bit and__arch64__layoutsportCONTEXT_SIZE/portMINUS_CONTEXT_SIZEwhen stack protection is enabledRoot cause
portSAVE_CONTEXTandportRESTORE_CONTEXTalready save and restorerslr/rshrunderXPAR_MICROBLAZE_USE_STACK_PROTECTION, but the offsets were not defined and the task context frame size did not include those fields.Validation
portSLR_OFFSET/portSHR_OFFSETwere missing before the patch.__arch64__FPU/no-FPU stack-protection combinations.git diff --checkI could not run the full MicroBlaze compile locally because
mb-gccis not installed in this Windows environment. The repository GitHub Actions workflow has a dedicated MicroBlazeV9 compile step that should cover this path.