Skip to content

Share dialog says 'Only you.' under 'Who has access' while the item has public links #407

Closed

Description

@BeSovereign

Where: web/src/components/ShareDialog.vue:257-262. The v-else on the member list shows share.onlyYou.

What happens: Open "Share …" on a file that has an active public link and no member share. The dialog says "Wer hat Zugriff: Nur du." (en: "Who has access: Only you.") and lists, directly below, the public link that anyone can open. #382 fixed this in the details drawer, which lists active links and says "Only you." only when there is neither (DetailsDrawer.vue:205-225). The share dialog still contradicts itself.

Expected: "Only you." appears only when there is neither a member share nor an active public link (not expired, downloads left), as in the drawer. With links but no members, a sentence says so, for example:

  • en: "No members. Anyone with a public link below can open it."
  • de-du and de-sie: "Keine Mitglieder. Wer einen der öffentlichen Links unten hat, kann es öffnen."

Fix: Compute the active links in ShareDialog. LinkManager already loads them, so it can emit them, or the dialog can share the query. Choose the sentence from both lists. Add the i18n key in all three locales.

Test (Playwright, e2e/shares.spec.ts): Create a public link for a file through the API and open "Share …". "Only you." is absent and the new sentence is shown. Revoke the link: "Only you." shows. Fails today.


Found by the automatic review round (claude-opus-5-5, b739414); per CLAUDE.md the fix starts with a failing behaviour test.

Activity

  1. added
    rebuildPart of the ground-up rebuild (spec 2026-10-14)
    qaFound by exploratory QA (dogfooding)
    on Oct 20, 2026
  2. added a commit that references this issue on Oct 20, 2026
  3. BeSovereign commented on Oct 20, 2026

    @BeSovereign
    ContributorAuthor

    Fixed: PR #416 squash-merged into main after green CI (one commit; git revert it to undo).

    • Suites: typecheck: 1 passed, 0 failed | lint: 1 passed, 0 failed | unit: 1187 passed, 0 failed | e2e: 611 passed, 0 failed
    • Declared tests fail without the production change and pass with it (output in the PR).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    qaFound by exploratory QA (dogfooding)rebuildPart of the ground-up rebuild (spec 2026-10-14)

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions