Skip to content

Favourites, Shared with me, My shares, Tag views start ~50 px below the title (others ~16  #408

Closed

Description

@BeSovereign

Where: An empty <p class="status" role="status"> sits right under the title in:

  • web/src/views/FavouritesView.vue:56
  • SharedView.vue:81
  • MySharesView.vue:107
  • TagView.vue:85

Its style is .status { min-height: 1.5em; margin: 0 0 var(--space-3) } (web/src/styles/app.css:461).

What happens (1280x800, en, title bottom → first content):

  • Favourites 49 px, Tag 49 px, Shared with me 51 px, My shares 52 px.
  • Recent 17 px, Trash 19 px, File requests 19 px, Members, Settings and Cloud accounts 16 px.

DESIGN.md says the Favourites view reuses the Recent table, yet the two tables start 32 px apart.

Expected: The gap under the title is the same on every view. An empty status line takes no room, or it sits under the list as in TrashView (TrashView.vue:129-131).

Fix: Move these status paragraphs below their lists, as TrashView does. Alternatively, add .status:empty { min-height: 0; margin: 0 } for the ones above content.

Test (Playwright, desktop): For /recent, /favourites, /shared, /my-shares and /tags/<t>, measure from the title's bottom to the first content's top. Assert that each is within 4 px of the /recent value. Fails today (49-52 vs 17).


Found by the automatic review round (claude-opus-5-5, b739414); per CLAUDE.md the fix starts with a failing behaviour test.

Activity

  1. added
    rebuildPart of the ground-up rebuild (spec 2026-10-14)
    qaFound by exploratory QA (dogfooding)
    on Oct 20, 2026
  2. added a commit that references this issue on Oct 20, 2026
  3. BeSovereign commented on Oct 20, 2026

    @BeSovereign
    ContributorAuthor

    Fixed: PR #417 squash-merged into main after green CI (one commit; git revert it to undo).

    • Suites: typecheck: 1 passed, 0 failed | lint: 1 passed, 0 failed | unit: 1187 passed, 0 failed | e2e: 614 passed, 0 failed
    • Declared tests fail without the production change and pass with it (output in the PR).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    qaFound by exploratory QA (dogfooding)rebuildPart of the ground-up rebuild (spec 2026-10-14)

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions