Repository navigation
fix(#402): Security (low): password-protected public link reveals the item's name before th - #411
Merged
Merged
Conversation
A locked public link's info() now returns only { locked: true }; name/type are optional in the shared type, and PublicLinkView shows a generic 'Protected link' heading from all three locales until unlock (recorded in DECISIONS.md). This round moves the #402 E2E checks into the existing password-link test, because the separate test's extra home folder pushed the shared home listing past the 200-row window and broke collision.spec.ts on mobile.
Refs #402
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Security review (claude-fable-5-1): no blocking finding. Fix is sound: locked info is a literal {locked:true}; list/content gate on requireUnlocked before any parsing; cookie binding unchanged; tests go red without the fix. Inert assertion: new test sends 'fs_link=forged' but the https harness cookie is '__Secure-fs_link' (pre-existing line 339 covers tampering). backendOf() still runs before the lock check in info/unlock (pre-existing). Schema could be a discriminated union. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #402
A locked public link's info() now returns only { locked: true }; name/type are optional in the shared type, and PublicLinkView shows a generic 'Protected link' heading from all three locales until unlock (recorded in DECISIONS.md). This round moves the #402 E2E checks into the existing password-link test, because the separate test's extra home folder pushed the shared home listing past the 200-row window and broke collision.spec.ts on mobile.
Driver gates (measured, not claimed)
red/green output
🤖 Generated with Claude Code